[DIRMINA-1059] NioProcessor's selector is synchronized but accessed outside

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.16
• Fix Version/s: 2.0.17
• Assignee: Unassigned
• Reporter: Emmanuel Lecharny
• Created: 06/Dec/16 05:07
• Updated: 06/Dec/16 07:46
• Resolved: 06/Dec/16 07:46

Description

We synchronize on the selector field in NioProcessor, but this field is accessed without synchronization :

    protected void doDispose() throws Exception {
        selector.close();
    }

and :

    protected boolean isBrokenConnection() throws IOException {
        // A flag set to true if we find a broken session
        boolean brokenSession = false;

        synchronized (selector) {
            ...

We should use another lock mechanism.