[DIRMINA-1056] IllegalArgumentException when setting max and minReadBufferSize > 65536 (default)

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.9
• Fix Version/s: 2.0.17
• Component/s: Transport
• Assignee: Unassigned
• Reporter: Spac Valentin
• Created: 29/Nov/16 12:55
• Updated: 30/Nov/16 06:27
• Resolved: 30/Nov/16 06:27

Description

After setting the max and minReadBufferSize to 256k on the acceptor's session config, the following error is thrown when a client connects:

java.lang.IllegalArgumentException: minReadBufferSize: 262144 (expected: smaller than 65536)
	at org.apache.mina.core.session.AbstractIoSessionConfig.setMinReadBufferSize(AbstractIoSessionConfig.java:110)
	at org.apache.mina.core.session.AbstractIoSessionConfig.setAll(AbstractIoSessionConfig.java:60)
	at org.apache.mina.transport.socket.nio.NioSocketSession.<init>(NioSocketSession.java:65)
	at org.apache.mina.transport.socket.nio.NioSocketAcceptor.accept(NioSocketAcceptor.java:200)
	at org.apache.mina.transport.socket.nio.NioSocketAcceptor.accept(NioSocketAcceptor.java:51)
	...

These two lines seems to be the problem

AbstractIoSessionConfig.java

 setMinReadBufferSize(config.getMinReadBufferSize());
 setMaxReadBufferSize(config.getMaxReadBufferSize());

This is due to the fact that there is a check when setting the minReadBuffer (it should be > than maxReadBufferSize) but the max isn't set yet so it compares it with the default value (64k).

Possible fix: just swap the lines, setting the maxReadBufferSize first.