Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.9
    • Fix Version/s: 2.0.10
    • Component/s: SSL
    • Labels:
      None

      Description

      Recently an optimisation was added (DIRMINA-1017) which can increase the capacity of member SslHandler.appBuffer. Testing found that whenever the buffer was increased, it was increased to ~16000 bytes, where only ~4000 bytes of that frame was being used.

      Similar to how SslHandler.fetchOutNetBuffer() returns the outNetBuffer with:
      ...
      return answer.shrink();

      could I recommend the same is done for SslHandler.fetchAppBuffer()?

      ...
      return appBuffer.shrink();

      Thanks,
      Terence

        Activity

        Hide
        elecharny Emmanuel Lecharny added a comment -

        Patch applied with http://git-wip-us.apache.org/repos/asf/mina/commit/bcf26ea2

        Thanks for it, and sorry for the delay !

        Show
        elecharny Emmanuel Lecharny added a comment - Patch applied with http://git-wip-us.apache.org/repos/asf/mina/commit/bcf26ea2 Thanks for it, and sorry for the delay !

          People

          • Assignee:
            Unassigned
            Reporter:
            tezm Terence Marks
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development