[DIRAPI-328] Fix inconsistency in Attribute and Value

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 3.0.0
• Assignee: Emmanuel Lécharny
• Reporter: Stefan Seelmann
• Created: 25/Nov/18 13:16
• Updated: 06/Nov/19 14:07

Description

Inconsistent method names:

• Attribute: getString() and getBytes()
• Value: getValue() and getBytes()
• Proposal: Rename Value.getValue() to Value.getString()

Inconsistent and wrong documented error handling:

• Attribute: getString() and getBytes() check for isHumanReadable and throw LdapInvalidAttributeValueException
• Value: getValue()/getString() tries to UTF-8 encode bytes if not human readable, which doesn't work always, and javadoc says "returns null"
• Value: getBytes() doesn't check if is human readable
• Proposal: Make Value behave like Attribute, i.e. throw LdapInvalidAttributeValueException

Opinions?