Uploaded image for project: 'Directory Client API'
  1. Directory Client API
  2. DIRAPI-261

OID don't encode corrctly joint-iso-itu-t arcs

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Critical
        • Resolution: Fixed
        • Affects Version/s: 1.0.0-M32
        • Fix Version/s: 1.0.0-M33
        • Labels:
          None

          Description

          The joint-iso-itu-t(2) arc is not encoded correctly : the second node is assumed to be below 40, which is not correct.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            Partial fix : http://svn.apache.org/viewvc?rev=1710496&view=rev

            This should handle the joint-iso-itu-t arc correctly (and the other too). It's mainly a fix for the fromString() method, which has been completely rewritten. Side result : it's also 2 times faster than the previous method (up to 3.5 millions OIDs parsed per second, compared to 1,77 million per second).

            The code is way more complex, based on a FSA (which is described on http://directory.staging.apache.org/api/user-guide/6.27-oid.html)

            What remains to be done : the fromBytes(byte[]) method does not handle correctly values longer than Long.MAX_VALUE, for the same reason.

            Show
            elecharny Emmanuel Lecharny added a comment - Partial fix : http://svn.apache.org/viewvc?rev=1710496&view=rev This should handle the joint-iso-itu-t arc correctly (and the other too). It's mainly a fix for the fromString() method, which has been completely rewritten. Side result : it's also 2 times faster than the previous method (up to 3.5 millions OIDs parsed per second, compared to 1,77 million per second). The code is way more complex, based on a FSA (which is described on http://directory.staging.apache.org/api/user-guide/6.27-oid.html ) What remains to be done : the fromBytes(byte[]) method does not handle correctly values longer than Long.MAX_VALUE , for the same reason.
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            The fromBytes() method is fixed by http://svn.apache.org/viewvc?rev=1710759&view=rev

            Show
            elecharny Emmanuel Lecharny added a comment - The fromBytes() method is fixed by http://svn.apache.org/viewvc?rev=1710759&view=rev

              People

              • Assignee:
                Unassigned
                Reporter:
                elecharny Emmanuel Lecharny
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development