Uploaded image for project: 'Directory Client API'
  1. Directory Client API
  2. DIRAPI-206

BindRequest logs exception on valid call to setter

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-M24
    • Fix Version/s: 1.0.0-M25
    • Labels:
      None

      Description

      We are using DIRAPI to connect to our corporate ActiveDirectory and it seems impossible to do so without getting an exception logged in our application log, even on successful operations. This is a concern since the exception creates noise potentially hiding real issues.

      The problem is described in http://t211471.apache-directory-api.apachetalks.us/binding-and-active-directory-t211471.html but the resolution is not sufficient for our purposes.

      The issue is caused by this bit of code in BindRequestImpl:

          public BindRequest setName( String name )
          {
              this.name = name;
      
              try
              {
                  this.dn = new Dn( name );
              }
              catch ( LdapInvalidDnException e )
              {
                  // This might still be a valid DN (Windows AD binding for instance)
                  LOG.info( "Unable to convert the name to a DN.", e );
                  this.dn = null;
              }
      
              return this;
          }
      

      The comment even indicates that the call might be perfectly valid. I think it would be much better to either drop the exception completely, or – if it is required in other scenarios – to skip the attempt of creating the DN field completely if some flag is set (extra parameter / field / subclass). Since the name field is private it can not be done from the client side.

      This is a potential showstopper for us – we do not like telling our support staff to ignore exceptions in logs.

        Attachments

          Activity

            People

            • Assignee:
              elecharny Emmanuel Lecharny
              Reporter:
              peter.becker.de Peter Becker
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: