[DIGESTER-171] Add DefaultThrowingErrorHandler to Digester API.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2
• Fix Version/s: 3.3
• Assignee: Simone Tripodi
• Reporter: Nick Williams
• Created: 10/Sep/12 15:43
• Updated: 18/Mar/13 08:44
• Resolved: 18/Mar/13 07:55

Description

The current default error handling behavior is for the SAX parses to NOT throw exceptions when they occur, but instead to log them to stderr. This is fine and I am not suggesting that be changed. However, there is a wiki article (http://wiki.apache.org/commons/Digester/FAQ) that describes the common task of implementing an error handler that throws encountered errors.

If this is so common, it would seem that including such an error handler in the API would be a very convenient thing to do.

I propose that the following class be added to the digester to make it convenient for anyone to turn on this behavior:

package org.apache.commons.digester3;

import org.xml.sax.ErrorHandler;
import org.xml.sax.SAXException;
import org.xml.sax.SAXParseException;

public class DefaultThrowingErrorHandler implements ErrorHandler
{
    @Override
    public void warning(SAXParseException e) throws SAXException
    {
        throw e;
    }

    @Override
    public void error(SAXParseException e) throws SAXException
    {
        throw e;
    }

    @Override
    public void fatalError(SAXParseException e) throws SAXException
    {
        throw e;
    }
}

Furthermore, I propose that the DigesterLoader and Digester classes have setThrowEncounteredSAXErrors(boolean) methods that set the error handler to the DefaultThrowingErrorHandler..