Commons Digester
  1. Commons Digester
  2. DIGESTER-115

Digester depends on BeanUtils copies of Collections classes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      This is related to issue# BEANUTILS-278

      Digester uses 3 classes (ArrayStack, Buffer and BufferUnderflowException) from commons BeanUtils which were copied from Commons Collections and BEANUTILS-278 proposes removing them.

      ArrayStack.java
      Buffer.java
      BufferUnderflowException.java

        Issue Links

          Activity

          Hide
          Rahul Akolkar added a comment -

          Fixed in trunk in r729242:

          http://svn.apache.org/viewvc?view=rev&revision=729242

          This is a breaking change, hence scheduled for v2.0. However, the positives seem to make the breakage worthwhile (making [digester] free of [collections] classes and allowing usage of generics for code clarity).

          Show
          Rahul Akolkar added a comment - Fixed in trunk in r729242: http://svn.apache.org/viewvc?view=rev&revision=729242 This is a breaking change, hence scheduled for v2.0. However, the positives seem to make the breakage worthwhile (making [digester] free of [collections] classes and allowing usage of generics for code clarity).
          Hide
          Rahul Akolkar added a comment -

          Moving to fix version v2.0, where we can fix this by using Stack instead and thus eliminating collections classes dependencies altogether.

          Show
          Rahul Akolkar added a comment - Moving to fix version v2.0, where we can fix this by using Stack instead and thus eliminating collections classes dependencies altogether.
          Hide
          Rahul Akolkar added a comment -

          But a "tighter" ArrayStack wouldn't work (given fix version is 1.8.1). In the longer run, I agree, we should wean [digester] off of the [collections] version of ArrayStack (doing what you suggest or just using java.util.Stack or some such so we will have one less class to maintain).

          Show
          Rahul Akolkar added a comment - But a "tighter" ArrayStack wouldn't work (given fix version is 1.8.1). In the longer run, I agree, we should wean [digester] off of the [collections] version of ArrayStack (doing what you suggest or just using java.util.Stack or some such so we will have one less class to maintain).
          Hide
          Henri Yandell added a comment -

          Note, it only directly depends on ArrayStack. Buffer and BufferUnderflowException are depended on via ArrayStack.

          A tighter ArrayStack could definitely be made (remove the unnecessary bits) and used within Digester.

          Show
          Henri Yandell added a comment - Note, it only directly depends on ArrayStack. Buffer and BufferUnderflowException are depended on via ArrayStack. A tighter ArrayStack could definitely be made (remove the unnecessary bits) and used within Digester.

            People

            • Assignee:
              Unassigned
              Reporter:
              Niall Pemberton
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development