[DERBY-974] ClientDriver can lose some connection properties

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.1.2.1, 10.1.3.1, 10.4.1.3
• Fix Version/s: 10.3.2.1, 10.4.1.3
• Component/s: Network Client
• Environment: Linux, Sun JRE 1.5
• Assignee: Jorgen Loland
• Reporter: Michael Hackett
• Created: 14/Feb/06 07:39
• Updated: 19/Feb/08 13:51
• Resolved: 22/Oct/07 11:17

Description

Internally, the ClientDriver class's appendDatabaseAttributes() method uses keys() on the connection properties to get a list of the property names. However, this misses any properties in the default set. The correct method for a Properties object is propertyNames(). This will return the same type of object as keys(), but will include all properties.

(It is unfortunate that Sun chose to make Properties a subclass of Hashtable, instead of giving Properties a Hashtable, as the former exposes too much implementation.)

The fix is to simply replace calls to keys() on all Property objects to use propertyNames(). A quick search revealed that this is not the only place in the code base where this is done, so a more thorough scan should be made.