Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6885

Remove ReuseFactory

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.13.1.0
    • Fix Version/s: 10.13.1.0
    • Component/s: Services
    • Labels:
      None

      Description

      ReuseFactory used to help reduce object allocations when converting numbers/booleans from primitive types to object types. After DERBY-2383 and DERBY-6230, the ReuseFactory methods are just wrappers around standard library methods such as Integer.valueOf() and Long.valueOf().

      Callers could just as easily call the corresponding valueOf() method directly, or rely on auto-boxing. Both ways use the same cache as ReuseFactory currently does, so ReuseFactory has no purpose anymore.

      One exception: ReuseFactory.getZeroLenByteArray() is still used and provides value, as it avoids the allocation cost when an empty byte array is needed. The ArrayUtil class is probably just as good a home for it, so I propose we move it there and remove the ReuseFactory class.

        Attachments

        1. d6885.diff
          54 kB
          Knut Anders Hatlen

          Activity

            People

            • Assignee:
              knutanders Knut Anders Hatlen
              Reporter:
              knutanders Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: