Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.11.1.1
    • Component/s: SQL
    • Urgency:
      Normal

      Description

      This piece of code once had a purpose in life. It was one of the double-joints which allowed cloudscape to ship with and without compiler support for the synchronization language. Synchronization has been removed. If we want to plug in optional language components, I think there are better ways to do this.

      The NodeFactory turned into a big, sprawling piece of code. At some point this code was slimmed down by telescoping all of its factory methods into a couple unwieldly, weakly-typed overloads backed by cumbersome logic in the actual node constructors. I would like to reintroduce strongly typed node constructors which the parser can call directly. This will make node generation easier to read and less brittle and it will get rid of the now useless NodeFactory class.

      1. nodefactory-31.zip
        105 kB
        Dag H. Wanvik
      2. nodefactory-31.status
        12 kB
        Dag H. Wanvik
      3. derby-673-1.diff.gz
        265 kB
        Dag H. Wanvik
      4. derby-673-1.status
        20 kB
        Dag H. Wanvik
      5. derby-673-2.diff.gz
        270 kB
        Dag H. Wanvik
      6. derby-673-2.status
        20 kB
        Dag H. Wanvik
      7. derby-673-3.diff.gz
        271 kB
        Dag H. Wanvik
      8. derby-673-3.status
        20 kB
        Dag H. Wanvik
      9. derby-673-fixcomments.diff
        2 kB
        Dag H. Wanvik
      10. derby-673-typesafe-lists-1.diff
        232 kB
        Dag H. Wanvik
      11. derby-673-typesafe-lists-1.status
        5 kB
        Dag H. Wanvik
      12. derby-673-typesafe-lists-2.status
        5 kB
        Dag H. Wanvik
      13. derby-673-typesafe-lists-2.diff.gz
        44 kB
        Dag H. Wanvik
      14. derby-673-more-typesafe-6.diff
        152 kB
        Dag H. Wanvik
      15. derby-673-more-typesafe-6.status
        5 kB
        Dag H. Wanvik
      16. derby-673-nuke-ctypes-enum.diff
        261 kB
        Dag H. Wanvik
      17. derby-673-nuke-ctypes-without-enum.diff
        264 kB
        Dag H. Wanvik
      18. derby-673-nuke-ctypes-enum.stat
        11 kB
        Dag H. Wanvik
      19. derby-673-nuke-ctypes-without-enum.status
        11 kB
        Dag H. Wanvik
      20. derby-673-nuke-ctypes-without-enum-2.diff
        275 kB
        Dag H. Wanvik
      21. derby-673-nuke-ctypes-without-enum-2.status
        11 kB
        Dag H. Wanvik
      22. derby-673-nuke-ctypes-without-enum-3.diff
        276 kB
        Dag H. Wanvik
      23. derby-673-nuke-ctypes-without-enum-3.status
        11 kB
        Dag H. Wanvik

        Issue Links

          Activity

          Rick Hillegas created issue -
          Daniel John Debrunner made changes -
          Field Original Value New Value
          Link This issue is related to DERBY-791 [ DERBY-791 ]
          Mike Matrigali made changes -
          Component/s SQL [ 11408 ]
          Dag H. Wanvik made changes -
          Issue Type New Feature [ 2 ] Improvement [ 4 ]
          Dag H. Wanvik made changes -
          Attachment nodefactory-31.zip [ 12586247 ]
          Attachment nodefactory-31.status [ 12586248 ]
          Dag H. Wanvik made changes -
          Assignee Dag H. Wanvik [ dagw ]
          Dag H. Wanvik made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-1.diff.gz [ 12588127 ]
          Attachment derby-673-1.status [ 12588128 ]
          Dag H. Wanvik made changes -
          Issue & fix info Patch Available [ 10102 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-2.diff.gz [ 12588843 ]
          Attachment derby-673-2.status [ 12588844 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-3.diff.gz [ 12589014 ]
          Attachment derby-673-3.status [ 12589015 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-fixcomments.diff [ 12589021 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-typesafe-lists-1.diff [ 12589554 ]
          Attachment derby-673-typesafe-lists-1.status [ 12589555 ]
          Mamta A. Satoor made changes -
          Labels derby_triage10_11
          Urgency Normal [ 10052 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-typesafe-lists-2.status [ 12589851 ]
          Attachment derby-673-typesafe-lists-2.diff.gz [ 12589852 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-more-typesafe-6.diff [ 12590199 ]
          Attachment derby-673-more-typesafe-6.status [ 12590200 ]
          Gavin made changes -
          Workflow jira [ 12343348 ] Default workflow, editable Closed status [ 12802220 ]
          Dag H. Wanvik made changes -
          Attachment derby-673-nuke-ctypes-enum.diff [ 12592970 ]
          Attachment derby-673-nuke-ctypes-without-enum.diff [ 12592971 ]
          Attachment derby-673-nuke-ctypes-enum.stat [ 12592972 ]
          Dag H. Wanvik made changes -
          Dag H. Wanvik made changes -
          Dag H. Wanvik made changes -
          Dag H. Wanvik made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Issue & fix info Patch Available [ 10102 ]
          Fix Version/s 10.11.0.0 [ 12324243 ]
          Resolution Fixed [ 1 ]
          Myrna van Lunteren made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Dag H. Wanvik
              Reporter:
              Rick Hillegas
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development