Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6515

ij doesn't list its command NoHoldForConnection in the help menu

    Details

    • Issue & fix info:
      Newcomer

      Description

      ij has a command to set the default holdability for a connection:

      Connection#setHoldability(ResultSet.CLOSE_CURSORS_AT_COMMIT)

      called "noholdforconnection". I think it should be documented and included in the inline help menu.

      1. index.html
        2 kB
        Myrna van Lunteren
      2. rtoolsijcomrefnohold.html
        9 kB
        Myrna van Lunteren
      3. DERBY_61515_doc.diff2
        3 kB
        Myrna van Lunteren
      4. DERBY-6515_src.diff2
        2 kB
        Myrna van Lunteren
      5. DERBY_6515_doc.diff
        3 kB
        Myrna van Lunteren
      6. DERBY-6515_src.diff
        1 kB
        Myrna van Lunteren

        Issue Links

          Activity

          Hide
          knutanders Knut Anders Hatlen added a comment -

          [ Automatically closing all resolved issues that haven't been updated in more than six months. ]

          Show
          knutanders Knut Anders Hatlen added a comment - [ Automatically closing all resolved issues that haven't been updated in more than six months. ]
          Hide
          myrna Myrna van Lunteren added a comment -

          I decided to not backport this - it involves a change to the (tools)messages which will remain untranslated. Also, adding the matching HoldForConnection (added with DERBY-6585) was an improvement, not a bug, and I think documenting this would make more sense if the HoldForConnection was also there.
          derby_backport_reject_10.10

          Show
          myrna Myrna van Lunteren added a comment - I decided to not backport this - it involves a change to the (tools)messages which will remain untranslated. Also, adding the matching HoldForConnection (added with DERBY-6585 ) was an improvement, not a bug, and I think documenting this would make more sense if the HoldForConnection was also there. derby_backport_reject_10.10
          Hide
          myrna Myrna van Lunteren added a comment -

          reopening for evaluation of backport to 10.10.

          Show
          myrna Myrna van Lunteren added a comment - reopening for evaluation of backport to 10.10.
          Hide
          dagw Dag H. Wanvik added a comment -

          I agree there should be a symmetrical HoldForConnection command as well; the NoHoldForConnection was probably added for some testing and as such it was good enough; one could always start another connection. For a general purpose tool, though, it looks like a careless omission.

          Show
          dagw Dag H. Wanvik added a comment - I agree there should be a symmetrical HoldForConnection command as well; the NoHoldForConnection was probably added for some testing and as such it was good enough; one could always start another connection. For a general purpose tool, though, it looks like a careless omission.
          Hide
          chaase3 Kim Haase added a comment -

          I'm sorry I didn't get to this in time – but the map file has the new command out of alphabetical order. It should come after Next, not before ...

          Show
          chaase3 Kim Haase added a comment - I'm sorry I didn't get to this in time – but the map file has the new command out of alphabetical order. It should come after Next, not before ...
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1596678 from Myrna van Lunteren in branch 'docs/trunk'
          [ https://svn.apache.org/r1596678 ]

          DERBY-6515; ij doesn't list its command NoHoldForConnection in the help menu
          adding a page on the NoHoldForConnection command to the tools guide

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1596678 from Myrna van Lunteren in branch 'docs/trunk' [ https://svn.apache.org/r1596678 ] DERBY-6515 ; ij doesn't list its command NoHoldForConnection in the help menu adding a page on the NoHoldForConnection command to the tools guide
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1596677 from Myrna van Lunteren in branch 'code/trunk'
          [ https://svn.apache.org/r1596677 ]

          DERBY-6515; ij doesn't list its command NoHoldForConnection in the help menu
          adding the NoHoldForConnection command to the help command output and updating one master file

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1596677 from Myrna van Lunteren in branch 'code/trunk' [ https://svn.apache.org/r1596677 ] DERBY-6515 ; ij doesn't list its command NoHoldForConnection in the help menu adding the NoHoldForConnection command to the help command output and updating one master file
          Hide
          myrna Myrna van Lunteren added a comment -

          Attaching a second version of the patches, plus the two html files affected by the doc change.
          I'll commit shortly.

          Show
          myrna Myrna van Lunteren added a comment - Attaching a second version of the patches, plus the two html files affected by the doc change. I'll commit shortly.
          Hide
          myrna Myrna van Lunteren added a comment -

          Hi Kim, thanks for the review. And no, there's no other ij commands relating to holdability...
          I did not check what is default value, my bad. I'll fix up the text as you suggest...(both in source and the docs).
          And I'll rename the doc page.

          Show
          myrna Myrna van Lunteren added a comment - Hi Kim, thanks for the review. And no, there's no other ij commands relating to holdability... I did not check what is default value, my bad. I'll fix up the text as you suggest...(both in source and the docs). And I'll rename the doc page.
          Hide
          chaase3 Kim Haase added a comment -

          Just another thought – for consistency, you might call the topic something like "rtoolsijcomrefnohold.dita" since the other command topics use this prefix. Just a nit, though. Consistency is not our strong suit.

          Show
          chaase3 Kim Haase added a comment - Just another thought – for consistency, you might call the topic something like "rtoolsijcomrefnohold.dita" since the other command topics use this prefix. Just a nit, though. Consistency is not our strong suit.
          Hide
          chaase3 Kim Haase added a comment -

          Thanks for doing the docs, Myrna! The topic looks good. I am a bit confused, though, because the discussions of holdability in the Developer's Guide say that holdability is the default, not NOHOLDABILITY. Did you mean to say something like

          "Sets the default holdability for a connection to NOHOLDABILITY (that is, to ResultSet.CLOSE_CURSORS_AT_COMMIT). By default, result sets are held open on commit. See "Scrollable result sets" in the Derby Developer's Guide for more information."

          Is there an ij command to change the default back to holdability?

          Show
          chaase3 Kim Haase added a comment - Thanks for doing the docs, Myrna! The topic looks good. I am a bit confused, though, because the discussions of holdability in the Developer's Guide say that holdability is the default, not NOHOLDABILITY. Did you mean to say something like "Sets the default holdability for a connection to NOHOLDABILITY (that is, to ResultSet.CLOSE_CURSORS_AT_COMMIT). By default, result sets are held open on commit. See "Scrollable result sets" in the Derby Developer's Guide for more information." Is there an ij command to change the default back to holdability?
          Hide
          myrna Myrna van Lunteren added a comment -

          attaching a patch for the code and for the doc part.
          Review - especially for the docs - will be appreciated.

          Show
          myrna Myrna van Lunteren added a comment - attaching a patch for the code and for the doc part. Review - especially for the docs - will be appreciated.

            People

            • Assignee:
              myrna Myrna van Lunteren
              Reporter:
              dagw Dag H. Wanvik
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development