Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6453

Remove dead code in InsertResultSet and flag skipCheckConstraints

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.11.1.1
    • Component/s: SQL
    • Labels:
      None
    • Urgency:
      Low

      Description

      I identified some unused code; a flag that is always false, and code for handling triggers in bulk insert which is unused (by inspection and corroborated by JaCoCo results for our regression tests): we disable bulk insert if there are triggers present, cf.

      • DMLModStatementNode#getAllRelevantTriggers ->
        adjustDeferredFlag(true)
      • InsertResultSet#bulkInsert:

      bulkInsert = verifyBulkInsert()->
      :
      // bulk insert is disabled for deferred mode inserts
      if (constants.deferred)
      return false;

        Attachments

        1. cleanup-misc-3.diff
          17 kB
          Dag H. Wanvik
        2. cleanup-misc-2.diff
          16 kB
          Dag H. Wanvik
        3. cleanup-misc-2.stat
          0.6 kB
          Dag H. Wanvik
        4. cleanup-misc.diff
          13 kB
          Dag H. Wanvik
        5. cleanup-misc.stat
          0.5 kB
          Dag H. Wanvik

          Issue Links

            Activity

              People

              • Assignee:
                dagw Dag H. Wanvik
                Reporter:
                dagw Dag H. Wanvik
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: