[DERBY-6453] Remove dead code in InsertResultSet and flag skipCheckConstraints

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.11.1.1
• Component/s: SQL
• Urgency: Low
• Assignee: Dag H. Wanvik
• Reporter: Dag H. Wanvik
• Created: 09/Jan/14 11:26
• Updated: 21/Jan/15 00:23
• Resolved: 09/Jan/14 20:35

Description

I identified some unused code; a flag that is always false, and code for handling triggers in bulk insert which is unused (by inspection and corroborated by JaCoCo results for our regression tests): we disable bulk insert if there are triggers present, cf.

• DMLModStatementNode#getAllRelevantTriggers ->
  adjustDeferredFlag(true)

• InsertResultSet#bulkInsert:

bulkInsert = verifyBulkInsert()->
:
// bulk insert is disabled for deferred mode inserts
if (constants.deferred)
return false;

Issue Links

• relates to: DERBY-532 Support deferrable constraints