[DERBY-6391] remove unneeded object creation in newException() calls in releases > 10.10

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.11.1.1
• Fix Version/s: 10.13.1.0
• Component/s: SQL, Store
• Labels: derby_backport_reject_10_10
• Issue & fix info: Known fix, Newcomer
• Assignee: Danoja Dias
• Reporter: Mike Matrigali
• Created: 23/Oct/13 19:52
• Updated: 01/Aug/16 06:23
• Resolved: 31/Jul/16 19:15

Description

In releases after 10.10 the code has been converted to use new
java language features. One of the benefits I just noticed is that
arguments to StandardException.newException() no longer have
to be Objects. I believe this is due to reimplementation using varargs.

As an example old code use to have to be written as:
throw StandardException.newException(
SQLState.FILE_BAD_CHECKSUM,
id,
new Long(checksum.getValue()),
new Long(onDiskChecksum),
pagedataToHexDump(pageData));

The only reason for the new Long() calls was to make them Objects so
that the call would match up to a hard coded N Object arg version of
the newException call. I believe these conversions to Objects are no
longer needed (but formatting of the args might change).

There may be code size savings to be had by doing this code
rototil.

Anyone see a downside to changing the code in this way?

Issue Links

• is depended upon by: DERBY-6870 Google Summer of Code 2016: Derby bug fixing
• relates to: DERBY-5873 Avoid unnecessary allocation of Number instances in client/server