Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6262

Simplify message-generating methods using varargs

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.11.1.1
    • 10.11.1.1
    • Miscellaneous
    • None

    Description

      I've found that many methods that generate messages could be collapsed into a single method using varargs. Right now, many of them exist in multiple variants, typically for zero up to three or four message arguments.

      Examples:
      Monitor.logTextMessage()
      MessageService.getTextMessage()
      Constructors in SqlException and SqlWarning

      Attachments

        1. derby-6262-05-a.diff
          6 kB
          Knut Anders Hatlen
        2. derby-6262-04-a.diff
          14 kB
          Knut Anders Hatlen
        3. derby-6262-03-a.diff
          7 kB
          Knut Anders Hatlen
        4. derby-6262-02-a.diff
          24 kB
          Knut Anders Hatlen
        5. derby-6262-01-a.diff
          20 kB
          Knut Anders Hatlen

        Issue Links

        relates to

        Improvement - An improvement or enhancement to an existing feature or task. DERBY-6254 Reduce number of factory methods in StandardException

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            knutanders Knut Anders Hatlen
            knutanders Knut Anders Hatlen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment