Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6163

Reduce visibility of methods in subclasses of PageBasicOperation

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.11.1.1
    • 10.11.1.1
    • Store
    • None

    Description

      org.apache.derby.impl.store.raw.data.PageBasicOperation and its subclasses are public. They are however never used outside of the package in which they live, so package access should be sufficient for most of their methods. Reducing the visibility of the classes and/or their methods silences many warnings in my IDE (NetBeans). Typically, the warnings are about public methods that have parameters of non-public types.

      Note: These classes implement Formatable, which requires that the classes are public and have public no-arg constructors. We can still reduce the visibility of the abstract classes in the hierarchy, as well as the specialized constructors that take arguments, since they are not used by the serialization logic.

      Attachments

        1. d6163-1a.diff
          30 kB
          Knut Anders Hatlen

        Activity

          People

            knutanders Knut Anders Hatlen
            knutanders Knut Anders Hatlen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: