Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Documentation
    • Labels:
      None
    • Urgency:
      Normal

      Description

      Varargs routines are ready to be documented. Hopefully, the functional spec attached to DERBY-3069 provides useful advice about what needs to be done.

      1. DERBY-6018.diff
        11 kB
        Kim Haase
      2. DERBY-6018.stat
        0.1 kB
        Kim Haase
      3. DERBY-6018.zip
        10 kB
        Kim Haase
      4. DERBY-6018-2.diff
        1 kB
        Kim Haase
      5. DERBY-6018-2.stat
        0.1 kB
        Kim Haase
      6. DERBY-6018-2.zip
        8 kB
        Kim Haase

        Issue Links

          Activity

          Rick Hillegas created issue -
          Rick Hillegas made changes -
          Field Original Value New Value
          Link This issue relates to DERBY-3069 [ DERBY-3069 ]
          Kim Haase made changes -
          Assignee Kim Haase [ chaase3 ]
          Hide
          Kim Haase added a comment -

          Attaching DERBY-6018.diff, DERBY-6018.stat, and DERBY-6018.zip, with changes to the following topics:

          M src/ref/rrefcreatefunctionstatement.dita
          M src/ref/rrefcreateprocedurestatement.dita

          I hope these fixes cover what needs to be said. I took advantage of the opportunity to make some minor tweaks elsewhere, mainly in the statements about forbidden data types. Hope I didn't introduce any errors. (I do wonder why essentially the same thing needs to be said in two different places. Could the second, under parameter style, be removed?)

          Please let me know what needs changing. Thanks!

          Show
          Kim Haase added a comment - Attaching DERBY-6018 .diff, DERBY-6018 .stat, and DERBY-6018 .zip, with changes to the following topics: M src/ref/rrefcreatefunctionstatement.dita M src/ref/rrefcreateprocedurestatement.dita I hope these fixes cover what needs to be said. I took advantage of the opportunity to make some minor tweaks elsewhere, mainly in the statements about forbidden data types. Hope I didn't introduce any errors. (I do wonder why essentially the same thing needs to be said in two different places. Could the second, under parameter style, be removed?) Please let me know what needs changing. Thanks!
          Kim Haase made changes -
          Attachment DERBY-6018.diff [ 12562972 ]
          Attachment DERBY-6018.stat [ 12562973 ]
          Attachment DERBY-6018.zip [ 12562974 ]
          Kim Haase made changes -
          Issue & fix info Patch Available [ 10102 ]
          Hide
          Rick Hillegas added a comment -

          Thanks, Kim. These changes look good to me and are worth committing as they are.

          In addition, I think it would be good to add some more documentation:

          o The section on CREATE PROCEDURE should say that DYNAMIC RESULT SETS must be 0 if the procedure takes varargs.

          o The section on "Argument Matching" should say that a varargs routine must resolve to a varargs Java method.

          Thanks,
          -Rick

          Show
          Rick Hillegas added a comment - Thanks, Kim. These changes look good to me and are worth committing as they are. In addition, I think it would be good to add some more documentation: o The section on CREATE PROCEDURE should say that DYNAMIC RESULT SETS must be 0 if the procedure takes varargs. o The section on "Argument Matching" should say that a varargs routine must resolve to a varargs Java method. Thanks, -Rick
          Hide
          Kim Haase added a comment -

          Thanks, Rick!

          Committed patch DERBY-6018.diff to documentation trunk at revision 1428414.

          I'll file a second patch for the additional work.

          Show
          Kim Haase added a comment - Thanks, Rick! Committed patch DERBY-6018 .diff to documentation trunk at revision 1428414. I'll file a second patch for the additional work.
          Hide
          Kim Haase added a comment -

          Attaching DERBY-6018-2.diff, DERBY-6018-2.stat, and DERBY-6018-2.zip, with changes to these topics:

          M src/ref/rrefcreateprocedurestatement.dita
          M src/ref/rrefsqljargmatching.dita

          Let me know if this meets expectations. Thanks!

          Show
          Kim Haase added a comment - Attaching DERBY-6018 -2.diff, DERBY-6018 -2.stat, and DERBY-6018 -2.zip, with changes to these topics: M src/ref/rrefcreateprocedurestatement.dita M src/ref/rrefsqljargmatching.dita Let me know if this meets expectations. Thanks!
          Kim Haase made changes -
          Attachment DERBY-6018-2.diff [ 12563101 ]
          Attachment DERBY-6018-2.stat [ 12563102 ]
          Attachment DERBY-6018-2.zip [ 12563103 ]
          Hide
          Rick Hillegas added a comment -

          Thanks, Kim. The second patch looks great. +1

          Show
          Rick Hillegas added a comment - Thanks, Kim. The second patch looks great. +1
          Hide
          Kim Haase added a comment -

          Thanks very much, Rick.

          Committed patch DERBY-6018-2.diff to documentation trunk at revision 1428885.

          Show
          Kim Haase added a comment - Thanks very much, Rick. Committed patch DERBY-6018 -2.diff to documentation trunk at revision 1428885.
          Kim Haase made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Issue & fix info Patch Available [ 10102 ]
          Fix Version/s 10.10.0.0 [ 12321550 ]
          Resolution Fixed [ 1 ]
          Hide
          Kim Haase added a comment -

          Closing, since the changes have appeared in the Latest Alpha Manuals.

          Show
          Kim Haase added a comment - Closing, since the changes have appeared in the Latest Alpha Manuals.
          Kim Haase made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12743062 ] Default workflow, editable Closed status [ 12801711 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          15d 23h 44m 1 Kim Haase 04/Jan/13 14:35
          Resolved Resolved Closed Closed
          20d 4h 18m 1 Kim Haase 24/Jan/13 18:54

            People

            • Assignee:
              Kim Haase
              Reporter:
              Rick Hillegas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development