Derby
  1. Derby
  2. DERBY-6002

Reference manual is unclear on when territory can be set

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.8.2.2, 10.9.1.0, 10.10.1.1
    • Fix Version/s: 10.8.3.3, 10.9.2.2, 10.10.1.1
    • Component/s: Documentation
    • Labels:
      None

      Description

      http://db.apache.org/derby/docs/dev/ref/rrefattrib56769.html

      First it says: "When creating or upgrading a database, use this attribute to associate a non-default territory with the database."

      Later it says: "The territory attribute is used only when creating a database."

      I believe the latter is correct, and we should drop "or upgrading" from the first sentence.

      1. DERBY-6002.diff
        2 kB
        Kim Haase
      2. DERBY-6002.stat
        0.1 kB
        Kim Haase
      3. DERBY-6002.zip
        5 kB
        Kim Haase

        Issue Links

          Activity

          Hide
          Knut Anders Hatlen added a comment -

          I tested it by first creating a database with territory=en in Derby 10.8.2.2:

          ij version 10.8
          ij> connect 'jdbc:derby:db;territory=en;create=true';
          ij> exit;

          Then I upgraded the database with 10.9.1.0 and set territory to no:

          ij version 10.9
          ij> connect 'jdbc:derby:db;territory=no;upgrade=true';
          ij> exit;

          After this, db/service.properties still said derby.serviceLocale=en, so I believe the territory attribute is ignored on upgrade.

          Show
          Knut Anders Hatlen added a comment - I tested it by first creating a database with territory=en in Derby 10.8.2.2: ij version 10.8 ij> connect 'jdbc:derby:db;territory=en;create=true'; ij> exit; Then I upgraded the database with 10.9.1.0 and set territory to no: ij version 10.9 ij> connect 'jdbc:derby:db;territory=no;upgrade=true'; ij> exit; After this, db/service.properties still said derby.serviceLocale=en, so I believe the territory attribute is ignored on upgrade.
          Hide
          Kim Haase added a comment -

          Thanks for catching this, Knut. I don't think we say anywhere else that the territory attribute can be used at upgrade time.

          I wonder if it also makes sense to change the "Restriction" note in http://db.apache.org/derby/docs/dev/devguide/tdevdvlpcollation.html from

          The collation attribute can be specified only when you create a database.

          to

          The collation and territory attributes can be specified only when you create a database.

          Since both attributes are mentioned in the preceding paragraph, readers might think that the restriction applies only to collation.

          Show
          Kim Haase added a comment - Thanks for catching this, Knut. I don't think we say anywhere else that the territory attribute can be used at upgrade time. I wonder if it also makes sense to change the "Restriction" note in http://db.apache.org/derby/docs/dev/devguide/tdevdvlpcollation.html from The collation attribute can be specified only when you create a database. to The collation and territory attributes can be specified only when you create a database. Since both attributes are mentioned in the preceding paragraph, readers might think that the restriction applies only to collation.
          Hide
          Kim Haase added a comment -

          Attaching DERBY-6002.diff, DERBY-6002.stat, and DERBY-6002.zip, with the following changed topics:

          M src/devguide/tdevdvlpcollation.dita
          M src/ref/rrefattrib56769.dita

          Comments are welcome. Thanks.

          Show
          Kim Haase added a comment - Attaching DERBY-6002 .diff, DERBY-6002 .stat, and DERBY-6002 .zip, with the following changed topics: M src/devguide/tdevdvlpcollation.dita M src/ref/rrefattrib56769.dita Comments are welcome. Thanks.
          Hide
          Knut Anders Hatlen added a comment -

          Thanks, Kim. It sounds like a good suggestion to change the note in the developer's guide too. +1

          Show
          Knut Anders Hatlen added a comment - Thanks, Kim. It sounds like a good suggestion to change the note in the developer's guide too. +1
          Hide
          Kim Haase added a comment -

          Thanks, Knut!

          I committed patch DERBY-6002.diff to the documentation trunk at revision 1413904.

          I'll commit it to the 10.8 branch too, but will hold off committing to the 10.9 branch and resolving until Lily is able to build the 10.9 docs successfully.

          Show
          Kim Haase added a comment - Thanks, Knut! I committed patch DERBY-6002 .diff to the documentation trunk at revision 1413904. I'll commit it to the 10.8 branch too, but will hold off committing to the 10.9 branch and resolving until Lily is able to build the 10.9 docs successfully.
          Hide
          Kim Haase added a comment -

          Merged patch DERBY-6002.diff to 10.8 doc branch at revision 1413915.

          Show
          Kim Haase added a comment - Merged patch DERBY-6002 .diff to 10.8 doc branch at revision 1413915.
          Hide
          Kim Haase added a comment -

          I gather the 10.9 branch is again open for checkins.

          Committed patch DERBY-6002.diff to 10.9 doc branch at revision 1418461.

          Show
          Kim Haase added a comment - I gather the 10.9 branch is again open for checkins. Committed patch DERBY-6002 .diff to 10.9 doc branch at revision 1418461.
          Hide
          Kim Haase added a comment -

          Closing, since the changes have appeared in the Latest Alpha Manuals.

          Show
          Kim Haase added a comment - Closing, since the changes have appeared in the Latest Alpha Manuals.

            People

            • Assignee:
              Kim Haase
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development