Derby
  1. Derby
  2. DERBY-5934

Convert store.ReEncryptCrashRecovery

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      Convert the old-style Java test store.ReEncryptCrashRecovery to JUnit.

      1. derby-5934-1a-converted_to_junit.diff
        66 kB
        Kristian Waagan
      2. derby-5934-1a-converted_to_junit.stat
        0.5 kB
        Kristian Waagan
      3. ReEncryptCrashRecoveryTest.java
        22 kB
        Kristian Waagan

        Issue Links

          Activity

          Hide
          Kristian Waagan added a comment -

          Test has been running for a few days without failures.
          Closing issue.

          Show
          Kristian Waagan added a comment - Test has been running for a few days without failures. Closing issue.
          Hide
          Kristian Waagan added a comment -

          Committed to trunk with revision 1392375.
          Awaiting results from automatic tests before closing.

          Show
          Kristian Waagan added a comment - Committed to trunk with revision 1392375. Awaiting results from automatic tests before closing.
          Hide
          Kristian Waagan added a comment -

          Attaching a proper diff. Also removes one master, removes the test from a runlist, and adds the new test to the store suite.

          Note that the test now only deletes the database(s) if the test passes. Otherwise the deletion will typically fail and mask the real error/problem.

          Patch ready for review.

          Show
          Kristian Waagan added a comment - Attaching a proper diff. Also removes one master, removes the test from a runlist, and adds the new test to the store suite. Note that the test now only deletes the database(s) if the test passes. Otherwise the deletion will typically fail and mask the real error/problem. Patch ready for review.
          Hide
          Kristian Waagan added a comment -

          Attaching first draft of the test.
          It runs, but I need to fix a few things first:
          o fix documentation and JavaDoc comments
          o complete cleanup
          o decide if the demonstrated database deletion code is ok. I'm considering adding a flag instructing the test to only delete the databases if the test passed. the logic could also be moved to tearDown if I use an instance variable.

          Ready for initial review/commenting.

          Show
          Kristian Waagan added a comment - Attaching first draft of the test. It runs, but I need to fix a few things first: o fix documentation and JavaDoc comments o complete cleanup o decide if the demonstrated database deletion code is ok. I'm considering adding a flag instructing the test to only delete the databases if the test passed. the logic could also be moved to tearDown if I use an instance variable. Ready for initial review/commenting.
          Hide
          Kristian Waagan added a comment -

          I plan to re-use this test for the decryption feature, so I'm marking it as a blocker for DERBY-5792.

          Show
          Kristian Waagan added a comment - I plan to re-use this test for the decryption feature, so I'm marking it as a blocker for DERBY-5792 .

            People

            • Assignee:
              Kristian Waagan
              Reporter:
              Kristian Waagan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development