[DERBY-5922] BaseDataFileFactory.stop() should provide better protection for a null storageFactory. Can cause NullPointerException if boot fails

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 10.9.1.0
• Component/s: Store
• Assignee: Mamta A. Satoor
• Reporter: Katherine Marsden
• Created: 11/Sep/12 17:18
• Updated: 15/Nov/13 08:15
• Resolved: 06/Oct/12 18:52

Description

DERBY-5916 was a report of a NullPointerException in BaseDataFileFactory.stop()

Although we don't know the root cause or have a reproduction of the problem reported in that issue. As Brian points out ..

"It sounds like there was such a severe error trying to start up the database that
we were trying to abort the startup and shutdown the parts that did start.

But we were in a state where, having failed to start up, we couldn't shut down, either.

BaseDataFileFactory.stop is very thorough with its null pointer checks, so it's not
easy to see how that code could get a NPE.

But I notice that line 532, the call to storageFactory.shutdown in this:

if (isReadOnly()) // do enough to close all files, then return

{ storageFactory.shutdown(); return; }

isn't protected by "if( storageFactory != null )"

Perhaps you could reproduce this artificially by arranging by forcing
the startup code to throw an exception at just the right point...
"

It would be good to fix at least the null checks. Perhaps the NullPointerException is masking the original error.