Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5896

Change java/drda source code to use spaces instead of tabs and clean up tab creep in java/client

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Server
    • Labels:
      None
    • Issue & fix info:
      Patch Available

      Description

      Change all the network server code under java/drda to use spaces instead of tabs.

      Having mixed tabs and spaces can be confusing, irritating and time consuming for developers especially in the network code where client is all spaces and the server mostly tabs.

      With the -x -b options on svn merge and svn diff, merges should be reasonable even if we change all the tabs to 4 spaces in the files under java/drda with a script something like (not yet tried):

      #!/bin/bash
      files=$@
      for file in $files
      {
      echo $file
      mv $file $file.orig
      sed -e 's/\t/ /g' < $file.orig > $file
      rm $file.orig
      }

      Are there any objections to this change? If not does anyone have any pending DRDA changes they would like to get in before I make the change?

        Attachments

        1. derby-5896-client-align-with-tab-stops.diff.txt
          7 kB
          Knut Anders Hatlen
        2. derby-5896-align-with-tab-stops.diff.txt
          191 kB
          Knut Anders Hatlen
        3. derby-5896_client_diff.txt
          120 kB
          Kathey Marsden
        4. derby-5896_client_stat.txt
          2 kB
          Kathey Marsden
        5. derby-5896_diff.txt
          1.38 MB
          Kathey Marsden
        6. derby-5896_stat.txt
          2 kB
          Kathey Marsden

          Activity

            People

            • Assignee:
              kmarsden Kathey Marsden
              Reporter:
              kmarsden Kathey Marsden
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: