Derby
  1. Derby
  2. DERBY-5827

Remove unused methods in NetStatementReply class

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Client
    • Labels:
      None

      Description

      Code inspection of the NetStatementReply class shows that the following methods are not used at all.

      parseQRYPRCTYP()
      parseSQLCSRHLD()
      parseQRYATTSCR()
      parseQRYATTSET()
      parseQRYATTSNS()
      parseQRYATTUPD()

      So it might be possible to remove these methods.

      1. DERBY-5827.patch
        5 kB
        Mohamed Nufail

        Activity

        Hide
        Mohamed Nufail added a comment -

        Attached the patch DERBY-5827.patch which removes the above mentioned 6 methods

        Show
        Mohamed Nufail added a comment - Attached the patch DERBY-5827 .patch which removes the above mentioned 6 methods
        Hide
        Bryan Pendleton added a comment -

        I am reviewing this patch.

        I looked at the svn history of NetStatementReply.java
        http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java?view=annotate
        and all of these methods seem to have been present since
        the original contribution of this class to Derby, and have not been
        modified since.

        I also independently searched the code, and I agree that these
        methods are entirely unused.

        I'm intending to commit this patch. Deleting this unused code seems
        fine, since the original implementation is still preserved in svn in case
        we want to revive any of these methods in the future.

        Show
        Bryan Pendleton added a comment - I am reviewing this patch. I looked at the svn history of NetStatementReply.java http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java?view=annotate and all of these methods seem to have been present since the original contribution of this class to Derby, and have not been modified since. I also independently searched the code, and I agree that these methods are entirely unused. I'm intending to commit this patch. Deleting this unused code seems fine, since the original implementation is still preserved in svn in case we want to revive any of these methods in the future.
        Hide
        Bryan Pendleton added a comment -

        My builds and tests were successful, and I've committed
        this change to the trunk as revision 1356065.

        Show
        Bryan Pendleton added a comment - My builds and tests were successful, and I've committed this change to the trunk as revision 1356065.
        Hide
        Bryan Pendleton added a comment -

        Thanks Nufail!

        Show
        Bryan Pendleton added a comment - Thanks Nufail!

          People

          • Assignee:
            Mohamed Nufail
            Reporter:
            Mohamed Nufail
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development