Derby
  1. Derby
  2. DERBY-5810

Include emma.jar on classpath when running compatibility test with instrumented jars

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      When running the compatibility test with EMMA instrumented jars, it fails because it starts sub-processes without putting emma.jar on their classpath. We should make it construct a working classpath for its sub-processes if it detects that it's running with instrumented jars.

      This will be easier to fix once DERBY-5808 is checked in.

      1. d5810-1a.diff
        3 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Knut Anders Hatlen created issue -
          Knut Anders Hatlen made changes -
          Field Original Value New Value
          Link This issue is blocked by DERBY-5808 [ DERBY-5808 ]
          Hide
          Knut Anders Hatlen added a comment -

          The attached patch is built on top of the 1a patch attached to DERBY-5808. It modifies BaseTestCase.execJavaCmd() so that it adds emma.jar to the classpath of the sub-processes when running with instrumented jars.

          This isn't needed for most callers of execJavaCmd(), as they typically inherit the classpath from the parent process, which already contains emma.jar. The compatibility tests are a bit different, as they set the classpath of their sub-processes explicitly in order to be able to mix and match the different versions.

          The compatibility tests ran successfully with instrumented jars when this patch, and the one for DERBY-5808, were applied.

          Show
          Knut Anders Hatlen added a comment - The attached patch is built on top of the 1a patch attached to DERBY-5808 . It modifies BaseTestCase.execJavaCmd() so that it adds emma.jar to the classpath of the sub-processes when running with instrumented jars. This isn't needed for most callers of execJavaCmd(), as they typically inherit the classpath from the parent process, which already contains emma.jar. The compatibility tests are a bit different, as they set the classpath of their sub-processes explicitly in order to be able to mix and match the different versions. The compatibility tests ran successfully with instrumented jars when this patch, and the one for DERBY-5808 , were applied.
          Knut Anders Hatlen made changes -
          Attachment d5810-1a.diff [ 12531820 ]
          Hide
          Knut Anders Hatlen added a comment -

          Committed r1350134.

          Show
          Knut Anders Hatlen added a comment - Committed r1350134.
          Knut Anders Hatlen made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 10.10.0.0 [ 12321550 ]
          Resolution Fixed [ 1 ]
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12673054 ] Default workflow, editable Closed status [ 12796756 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          1d 20h 22m 1 Knut Anders Hatlen 14/Jun/12 08:57
          Resolved Resolved Closed Closed
          40d 8h 33m 1 Knut Anders Hatlen 24/Jul/12 17:31

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development