Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5771

Use TestNullOutputStream where possible

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      Derby's test framework provides a stream class, TestNullOutputStream, that discards all data written to it. Utf8CcsidManagerClientTest's constructor and BaseJDBCTestCase.runScript() create their own anonymous classes that provide the same functionality. They should be changed to reuse TestNullOutputStream.

      1. d5771-1a.diff
        3 kB
        Knut Anders Hatlen

        Activity

        Hide
        knutanders Knut Anders Hatlen added a comment -

        Attaching a patch that makes the suggested changes.

        Show
        knutanders Knut Anders Hatlen added a comment - Attaching a patch that makes the suggested changes.
        Hide
        kristwaa Kristian Waagan added a comment -

        +1

        Show
        kristwaa Kristian Waagan added a comment - +1
        Hide
        knutanders Knut Anders Hatlen added a comment -

        Thanks, Kristian. Committed revision 1341814.

        Show
        knutanders Knut Anders Hatlen added a comment - Thanks, Kristian. Committed revision 1341814.

          People

          • Assignee:
            knutanders Knut Anders Hatlen
            Reporter:
            knutanders Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development