Derby
  1. Derby
  2. DERBY-5733

Source file for OrderByAndSortAvoidance contains characters not available in the C locale

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      The test lang.OrderByAndSortAvoidance contains characters that can't be mapped to 7-bit ASCII. This results in warnings when generating the Javadocs.
      For instance:
      java/testing/org/apache/derbyTesting/functionTests/tests/lang/OrderByAndSortAvoidance.java:2959: warning: unmappable character for encoding ASCII
      insertTable2(it2, 15032385537L, "BatchTypeInstructions", "Ne pas jeter ces documents. Ils ont t faits pour quelque chose.");

      This can be remedied by using a different system locale, but the question is whether we should use char literals in the source code instead?
      Most systems use the C locale by default, as is the case for (at least one of) the build servers we use (search for "Ils ont" or move down a few pages):
      https://builds.apache.org/job/Derby-trunk/1306/console

      1. d5733-1a.diff
        18 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Kristian Waagan created issue -
          Hide
          Knut Anders Hatlen added a comment -

          Oops... I fixed up this test a while ago and made it use escape sequences as suggested. But then I forgot about it when I wrote the script that helped me rewrite it in DERBY-5695, and the unescaped characters reappeared. I'll fix it again.

          Show
          Knut Anders Hatlen added a comment - Oops... I fixed up this test a while ago and made it use escape sequences as suggested. But then I forgot about it when I wrote the script that helped me rewrite it in DERBY-5695 , and the unescaped characters reappeared. I'll fix it again.
          Knut Anders Hatlen made changes -
          Field Original Value New Value
          Assignee Knut Anders Hatlen [ knutanders ]
          Knut Anders Hatlen made changes -
          Link This issue is broken by DERBY-5695 [ DERBY-5695 ]
          Knut Anders Hatlen made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Knut Anders Hatlen added a comment -

          Attached is a patch that replaces the problematic characters with escape sequences. Verified that the test still passes, and that ant testingdocs doesn't emit any warnings in C locale.

          Show
          Knut Anders Hatlen added a comment - Attached is a patch that replaces the problematic characters with escape sequences. Verified that the test still passes, and that ant testingdocs doesn't emit any warnings in C locale.
          Knut Anders Hatlen made changes -
          Attachment d5733-1a.diff [ 12525080 ]
          Hide
          Kristian Waagan added a comment -

          Thanks, Knut.

          +1 to commit

          Show
          Kristian Waagan added a comment - Thanks, Knut. +1 to commit
          Hide
          Knut Anders Hatlen added a comment -

          Thanks, Kristian.
          Committed revision 1332938.

          Show
          Knut Anders Hatlen added a comment - Thanks, Kristian. Committed revision 1332938.
          Knut Anders Hatlen made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Fix Version/s 10.9.0.0 [ 12316344 ]
          Resolution Fixed [ 1 ]
          Hide
          Kristian Waagan added a comment -

          Closing issue, I can no longer see the warnings in Derby-trunk build #1312 ([1]).

          [1] https://builds.apache.org/job/Derby-trunk/1312/

          Show
          Kristian Waagan added a comment - Closing issue, I can no longer see the warnings in Derby-trunk build #1312 ( [1] ). [1] https://builds.apache.org/job/Derby-trunk/1312/
          Kristian Waagan made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12664835 ] Default workflow, editable Closed status [ 12796988 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          8h 1m 1 Knut Anders Hatlen 30/Apr/12 18:02
          In Progress In Progress Resolved Resolved
          1d 14h 15m 1 Knut Anders Hatlen 02/May/12 08:18
          Resolved Resolved Closed Closed
          1h 45m 1 Kristian Waagan 02/May/12 10:03

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Kristian Waagan
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development