Derby
  1. Derby
  2. DERBY-5724

EncryptionKeyTest sometimes keeps reference to connection

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      EncryptionKeyTest has this code to clean up the connection:

      if (con != null && !con.isClosed())

      { con.rollback(); con.close(); con = null; }

      If the connection is already closed, it won't null out the reference. It should set con to null unconditionally.

      1. d5724-1a.diff
        0.9 kB
        Knut Anders Hatlen

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        1d 19h 24m 1 Knut Anders Hatlen 27/Apr/12 08:22
        Gavin made changes -
        Workflow jira [ 12664068 ] Default workflow, editable Closed status [ 12796981 ]
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Issue & fix info Patch Available [ 10102 ]
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Resolution Fixed [ 1 ]
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1331265.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1331265.
        Knut Anders Hatlen made changes -
        Summary EncryptionKeyTest sometimes keep reference to connection EncryptionKeyTest sometimes keeps reference to connection
        Assignee Knut Anders Hatlen [ knutanders ]
        Issue & fix info Patch Available [ 10102 ]
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Attachment d5724-1a.diff [ 12524283 ]
        Hide
        Knut Anders Hatlen added a comment -

        Attaching a patch that makes tearDown() null out the connection unconditionally.

        Show
        Knut Anders Hatlen added a comment - Attaching a patch that makes tearDown() null out the connection unconditionally.
        Knut Anders Hatlen created issue -

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development