Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5719

UniqueConstraintMultiThreadedTest doesn't call super.tearDown()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      UniqueConstraintMultiThreadedTest has a tearDown() method that doesn't call super.tearDown().

      It also keeps a DataSource in an instance variable and doesn't appear to null out the reference to it on completion.

      1. d5719-1a.diff
        5 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Hide
          knutanders Knut Anders Hatlen added a comment -

          Attaching a patch that makes the following changes to the test:

          • Call super.tearDown() from the override
          • Use framework helper methods to simplify setUp() and tearDown()
          • Eliminate the shared DataSource instance (use openDefaultConnection() instead)
          • Remove unused imports
          • Fix some typos in javadoc comments
          Show
          knutanders Knut Anders Hatlen added a comment - Attaching a patch that makes the following changes to the test: Call super.tearDown() from the override Use framework helper methods to simplify setUp() and tearDown() Eliminate the shared DataSource instance (use openDefaultConnection() instead) Remove unused imports Fix some typos in javadoc comments
          Hide
          knutanders Knut Anders Hatlen added a comment -

          Committed revision 1330203.

          Show
          knutanders Knut Anders Hatlen added a comment - Committed revision 1330203.

            People

            • Assignee:
              knutanders Knut Anders Hatlen
              Reporter:
              knutanders Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development