Derby
  1. Derby
  2. DERBY-5716

TimestampArithTest keeps references to statements after completion

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      TimestampArithTest keeps references to statements in static fields, but never closes them or clears the fields.

      1. d5716-1a.diff
        9 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Attaching a patch that makes two changes to the test:

        1) It adds a tearDown() method that closes the statements and clears the references to them.

        2) This is a data-driven test. However, the test inputs are stored in non-static variables, so they are duplicated in memory as many times as there are test cases. The patch makes the variables that hold the test input static to reduce the memory footprint of the test.

        Show
        Knut Anders Hatlen added a comment - Attaching a patch that makes two changes to the test: 1) It adds a tearDown() method that closes the statements and clears the references to them. 2) This is a data-driven test. However, the test inputs are stored in non-static variables, so they are duplicated in memory as many times as there are test cases. The patch makes the variables that hold the test input static to reduce the memory footprint of the test.
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1330207.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1330207.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development