[DERBY-5704] Various cleanups in CoalesceTest

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.9.1.0
• Fix Version/s: 10.9.1.0
• Component/s: Test
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 23/Apr/12 11:14
• Updated: 25/Apr/12 11:19
• Resolved: 25/Apr/12 11:19

Description

I noticed a couple of things that could be cleaned up in CoalesceTest:

• It keeps statements in instance variables. These are closed in tearDown(), but not nulled out, so they are not gc'ed when the test completes.

• It has much code that follows the pattern

try

{ s.execute(...); }

catch (SQLException sqle)

{ assertSQLState(state, sqle); }

which means it won't report a failure if the execution of the statement succeeds unexpectedly.