Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5704

Various cleanups in CoalesceTest

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      I noticed a couple of things that could be cleaned up in CoalesceTest:

      • It keeps statements in instance variables. These are closed in tearDown(), but not nulled out, so they are not gc'ed when the test completes.
      • It has much code that follows the pattern

      try

      { s.execute(...); }

      catch (SQLException sqle)

      { assertSQLState(state, sqle); }

      which means it won't report a failure if the execution of the statement succeeds unexpectedly.

        Attachments

        1. d5704-1a.diff
          21 kB
          Knut Anders Hatlen

          Activity

            People

            • Assignee:
              knutanders Knut Anders Hatlen
              Reporter:
              knutanders Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: