Derby
  1. Derby
  2. DERBY-5641

Remove unused BaseDataFileFactory methods plus minor cleanups

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Store
    • Labels:
      None

      Description

      BaseDataFileFactory has some unused methods, they can be removed: syncSideLog, pageToDirty and getTempDirectory
      In addition I suggest the following cleanups:
      o remove unused imports
      o remove unnecessary return statement
      o make synchronization object freezeSemaphore final
      o remove unused instance variable backupPath
      o remove unused local variable (and exception instantiation) multipleJBMSWarning
      o replace new Boolean with Boolean.valueOf

        Activity

        Kristian Waagan created issue -
        Hide
        Kristian Waagan added a comment -

        Attaching patch 1a which implements the changes described above.

        Tests ran successfully on Solaris 11:
        15356 tests executed
        0 errors
        0 failures

        Patch ready for review.

        Show
        Kristian Waagan added a comment - Attaching patch 1a which implements the changes described above. Tests ran successfully on Solaris 11: 15356 tests executed 0 errors 0 failures Patch ready for review.
        Kristian Waagan made changes -
        Field Original Value New Value
        Attachment derby-5641-1a-unused_methods_plus_cleanup.diff [ 12517386 ]
        Kristian Waagan made changes -
        Issue & fix info Patch Available [ 10102 ]
        Hide
        Knut Anders Hatlen added a comment -

        Looks like a good cleanup. +1

        Show
        Knut Anders Hatlen added a comment - Looks like a good cleanup. +1
        Hide
        Kristian Waagan added a comment -

        Thanks, Knut.

        Committed patch 1a to trunk with revision 1298709.

        Show
        Kristian Waagan added a comment - Thanks, Knut. Committed patch 1a to trunk with revision 1298709.
        Kristian Waagan made changes -
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Issue & fix info Patch Available [ 10102 ]
        Assignee Kristian Waagan [ kristwaa ]
        Hide
        Kristian Waagan added a comment -

        Closing.

        Show
        Kristian Waagan added a comment - Closing.
        Kristian Waagan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow jira [ 12656932 ] Default workflow, editable Closed status [ 12796977 ]

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development