Derby
  1. Derby
  2. DERBY-5627

Remove unused methods in UUID classes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Services
    • Labels:
      None

      Description

      The UUIDFactory and UUID interfaces (and their implementations) contain some unused methods that could be removed:

      UUIDFactory/BasicUUIDFactory: The method recreateUUID(byte[]) is not used, except in a unit test (T_UUIDFactory)

      UUID/BasicUUID: The methods toByteArray() and toHexString() are never called, and the constructor BasicUUID(byte[]) is only called by the unused recreateUUID() factory method.

      1. d5627-1a.diff
        6 kB
        Knut Anders Hatlen

        Activity

        Knut Anders Hatlen created issue -
        Hide
        Knut Anders Hatlen added a comment -

        Attaching a patch that removes the methods. It also removes the call to the otherwise unused recreateUUID() method from T_UUIDFactory.

        All the regression tests ran cleanly with the patch.

        Show
        Knut Anders Hatlen added a comment - Attaching a patch that removes the methods. It also removes the call to the otherwise unused recreateUUID() method from T_UUIDFactory. All the regression tests ran cleanly with the patch.
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Attachment d5627-1a.diff [ 12515747 ]
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1293147.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1293147.
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Issue & fix info Patch Available [ 10102 ]
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow jira [ 12654548 ] Default workflow, editable Closed status [ 12796935 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        20h 47m 1 Knut Anders Hatlen 24/Feb/12 09:50

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development