[DERBY-5560] Java deadlock between LogicalConnection40 and ClientXAConnection40 (patch attached)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.8.2.2
• Fix Version/s: 10.8.3.3, 10.9.2.2, 10.10.2.0, 10.11.1.1
• Component/s: Network Client
• Labels: derby_triage10_11
• Environment: Solaris 10; Glassfish V2.1.1 ; ClientXADataSource connection pool setup to close all connections on any error
• Urgency: Urgent
• Issue & fix info: High Value Fix, Patch Available
• Bug behavior facts: Crash, Performance, Seen in production
• Assignee: Katherine Marsden
• Reporter: Brett Bergquist
• Created: 28/Dec/11 15:12
• Updated: 21/Jan/15 00:23
• Resolved: 14/Aug/13 20:25

Description

There is a Java deadlock between LogicalConnection40 and ClientXAConnection40. The order of calls that cause the deadlock are:

Thread 1

---

LogicalConnection.close
ClientPooledConnection.recycleConnection

Thread 2

---

ClientPooledConnection.close
LogicalConnection.nullPhysicalConnection

Thread 1 acquires a lock on the LogicalConnection and attempts to acquire a lock on the ClientPooledConnection
Thread 2 acquires a lock on the ClientPooledConnection and attempts to acquire a lock on the LogicalConnection

In production this occurs when one thread is committing a transaction and another thread is trying to close the connection. This occurred because the Glassfish connection pool is setup to close all connections on any error on any connection and an error has been detected on another connection in the pool.