Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5540

Call initCause() and getCause() without reflection in BaseJDBCTestCase

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      BaseJDBCTestCase uses reflection to call Throwable.initCause() and Throwable.getCause(). This was needed when running the tests on Java 1.3 and on Foundation Profile 1.0, but those platforms aren't supported any more. Now we should call the methods directly.

      1. d5540.diff
        4 kB
        Knut Anders Hatlen

        Activity

        Hide
        knutanders Knut Anders Hatlen added a comment -

        The attached patch makes BaseJDBCTestCase call initCause() and getCause() directly. All the regression tests passed.

        Show
        knutanders Knut Anders Hatlen added a comment - The attached patch makes BaseJDBCTestCase call initCause() and getCause() directly. All the regression tests passed.
        Hide
        dagw Dag H. Wanvik added a comment -

        Good cleanup. +1

        Show
        dagw Dag H. Wanvik added a comment - Good cleanup. +1
        Hide
        knutanders Knut Anders Hatlen added a comment -

        Thanks, Dag! Committed revision 1220669.

        Show
        knutanders Knut Anders Hatlen added a comment - Thanks, Dag! Committed revision 1220669.

          People

          • Assignee:
            knutanders Knut Anders Hatlen
            Reporter:
            knutanders Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development