Derby
  1. Derby
  2. DERBY-5540

Call initCause() and getCause() without reflection in BaseJDBCTestCase

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      BaseJDBCTestCase uses reflection to call Throwable.initCause() and Throwable.getCause(). This was needed when running the tests on Java 1.3 and on Foundation Profile 1.0, but those platforms aren't supported any more. Now we should call the methods directly.

      1. d5540.diff
        4 kB
        Knut Anders Hatlen

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        43m 26s 1 Knut Anders Hatlen 15/Dec/11 13:04
        In Progress In Progress Resolved Resolved
        3d 20h 38m 1 Knut Anders Hatlen 19/Dec/11 09:43
        Resolved Resolved Closed Closed
        218d 7h 43m 1 Knut Anders Hatlen 24/Jul/12 18:26
        Gavin made changes -
        Workflow jira [ 12646008 ] Default workflow, editable Closed status [ 12796862 ]
        Knut Anders Hatlen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Knut Anders Hatlen made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Issue & fix info Patch Available [ 10102 ]
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Resolution Fixed [ 1 ]
        Hide
        Knut Anders Hatlen added a comment -

        Thanks, Dag! Committed revision 1220669.

        Show
        Knut Anders Hatlen added a comment - Thanks, Dag! Committed revision 1220669.
        Hide
        Dag H. Wanvik added a comment -

        Good cleanup. +1

        Show
        Dag H. Wanvik added a comment - Good cleanup. +1
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Knut Anders Hatlen made changes -
        Issue & fix info Patch Available [ 10102 ]
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Attachment d5540.diff [ 12507510 ]
        Hide
        Knut Anders Hatlen added a comment -

        The attached patch makes BaseJDBCTestCase call initCause() and getCause() directly. All the regression tests passed.

        Show
        Knut Anders Hatlen added a comment - The attached patch makes BaseJDBCTestCase call initCause() and getCause() directly. All the regression tests passed.
        Knut Anders Hatlen created issue -

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development