Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5535

Remove unused methods from client's CrossConverters class.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.9.1.0
    • Component/s: Network Client
    • Labels:
      None

      Description

      The following methods in CrossConverters are not used (client code uses an optimized path, cf. e.g. getInt in am.Cursor.java which has this comment "For performance we don't materialize the BigDecimal, but convert directly from decimal bytes to a long"):

      getBooleanFromBigDecimal
      getByteFromBigDecimal
      getShortFromBigDecimal
      getIntFromBigDecimal
      getLongFromBigDecimal
      getFloatFromBigDecimal
      getDoubleFromBigDecimal

      1. derby-5535.diff
        4 kB
        Dag H. Wanvik

        Activity

        Hide
        dagw Dag H. Wanvik added a comment -

        Attaching a patch to remove the unused methods.

        Show
        dagw Dag H. Wanvik added a comment - Attaching a patch to remove the unused methods.
        Hide
        dagw Dag H. Wanvik added a comment -

        Regressions ran ok, committed patch at svn 1214423, closing.

        Show
        dagw Dag H. Wanvik added a comment - Regressions ran ok, committed patch at svn 1214423, closing.

          People

          • Assignee:
            dagw Dag H. Wanvik
            Reporter:
            dagw Dag H. Wanvik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development