Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Build tools
    • Labels:
      None

      Description

      The binscripts build target takes around 3 seconds in the environments I use for building Derby. It looks like most of the time is spent running the chmod Ant task on the generated scripts. There are six invocations of the chmod task, one for each script. The chmod task can operate on multiple files, so one invocation should be enough (and one invocation on six files seems to have about the same cost as one invocation on a single file).

      A related problem is that the scripts are always regenerated in incremental builds, even when there's nothing to do, so the binscripts target accounts for a significant part of the time it takes to run an incremental build.

      1. d5478.diff
        2 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        The attached patch factors out the chmod call so that it's only done once, and it also adds a little bit of logic to prevent that the scripts are rebuilt when they're already up to date.

        Show
        Knut Anders Hatlen added a comment - The attached patch factors out the chmod call so that it's only done once, and it also adds a little bit of logic to prevent that the scripts are rebuilt when they're already up to date.
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1189065.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1189065.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development