[DERBY-5426] Improve the error raised by too much contention on a sequence/identity.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.8.2.2, 10.9.1.0
• Fix Version/s: 10.8.2.2, 10.9.1.0
• Component/s: SQL
• Urgency: Blocker
• Issue & fix info: Newcomer
• Assignee: Richard N. Hillegas
• Reporter: Richard N. Hillegas
• Created: 21/Sep/11 22:51
• Updated: 07/Jul/18 02:01
• Resolved: 29/Sep/11 23:56

Description

Currently, when there is too much contention on a sequence/identity, Derby raises an error saying so. There are two properties which the user can adjust in order to reduce the risk of this error:

derby.locks.waitTimeout
derby.language.sequence.preallocator

It would be good to point the user at these knobs. The following change would improve this error reporting:

1) Raise a lock timeout SQLException

2) Chain a "too much contention" SQLException (X0Y84) to the lock timeout.

3) Make the "too much contention" exception suggest that the user adjust the properties mentioned above.

To make the code easier to understand, the exception raising could replace the loop exit inside the following "if" block in SequenceUpdater.getCurrentValueAndAdvance():

if (
(_lockTimeoutInMillis >= 0L) &&
( (System.currentTimeMillis() - startTime.longValue()) > _lockTimeoutInMillis )
)

{ break; }

This approach was recommended by the discussion on DERBY-5423.

Issue Links

• is related to: DERBY-7002 Change the text of X0Y84 to advise users to tune the value of derby.language.sequence.preallocator
• relates to: DERBY-5423 ERROR X0Y84: Too much contention on sequence NSTESTTAB in ns system test
• relates to: DERBY-712 Support for sequences
• relates to: DERBY-4437 Concurrent inserts into table with identity column perform poorly