Derby
  1. Derby
  2. DERBY-5418

Network server session's close method neglects to close down any open trace file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.1.1.0, 10.1.2.1, 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4, 10.3.2.1, 10.3.3.0, 10.4.1.3, 10.4.2.0, 10.5.1.1, 10.5.2.0, 10.5.3.0, 10.6.1.0, 10.6.2.1, 10.7.1.1, 10.8.1.2
    • Fix Version/s: 10.8.2.2, 10.9.1.0
    • Component/s: Network Server
    • Labels:
      None

      Description

      When shutting down a network server with open sessions and tracing is enabled, this can lead to file handles remaining indefinitely open (till OS process dies). When the server instance shuts down, it calls the open sessions' close method to reclaim resources. That method, unfortunately, does not shut down any open trace file.

      I saw this when debugging a test on Windows which tried to delete the trace files after shutting down the server.

      1. derby-5418.diff
        0.5 kB
        Dag H. Wanvik

        Activity

        Dag H. Wanvik created issue -
        Dag H. Wanvik made changes -
        Field Original Value New Value
        Summary Network server session's close method neglect to close down any open trace file Network server session's close method neglects to close down any open trace file
        Hide
        Dag H. Wanvik added a comment -

        Uploading a patch which fixes this issue.

        Show
        Dag H. Wanvik added a comment - Uploading a patch which fixes this issue.
        Dag H. Wanvik made changes -
        Attachment derby-5418.diff [ 12494890 ]
        Dag H. Wanvik made changes -
        Assignee Dag H. Wanvik [ dagw ]
        Hide
        Knut Anders Hatlen added a comment -

        The patch looks safe to me. +1 to commit.

        Show
        Knut Anders Hatlen added a comment - The patch looks safe to me. +1 to commit.
        Hide
        Dag H. Wanvik added a comment -

        Thanks, Knut. Regressions passed, committed as svn 1173446.

        Show
        Dag H. Wanvik added a comment - Thanks, Knut. Regressions passed, committed as svn 1173446.
        Dag H. Wanvik made changes -
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Affects Version/s 10.8.1.2 [ 12316362 ]
        Affects Version/s 10.7.1.1 [ 12315564 ]
        Affects Version/s 10.6.2.1 [ 12315343 ]
        Affects Version/s 10.6.1.0 [ 12313727 ]
        Affects Version/s 10.5.3.0 [ 12314117 ]
        Affects Version/s 10.5.2.0 [ 12314116 ]
        Affects Version/s 10.5.1.1 [ 12313771 ]
        Affects Version/s 10.4.2.0 [ 12313345 ]
        Affects Version/s 10.4.1.3 [ 12313111 ]
        Affects Version/s 10.3.3.0 [ 12313142 ]
        Affects Version/s 10.3.2.1 [ 12312876 ]
        Affects Version/s 10.3.1.4 [ 12312590 ]
        Affects Version/s 10.2.2.0 [ 12312027 ]
        Affects Version/s 10.2.1.6 [ 11187 ]
        Affects Version/s 10.1.3.1 [ 12311953 ]
        Affects Version/s 10.1.2.1 [ 12310615 ]
        Affects Version/s 10.1.1.0 [ 10993 ]
        Hide
        Dag H. Wanvik added a comment -

        Backported to the 10.8 branch as svn 1173450, closing.

        Show
        Dag H. Wanvik added a comment - Backported to the 10.8 branch as svn 1173450, closing.
        Dag H. Wanvik made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 10.8.2.2 [ 12317968 ]
        Resolution Fixed [ 1 ]
        Dag H. Wanvik made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow jira [ 12633421 ] Default workflow, editable Closed status [ 12801155 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4d 1h 41m 1 Dag H. Wanvik 21/Sep/11 02:12
        Resolved Resolved Closed Closed
        22s 1 Dag H. Wanvik 21/Sep/11 02:12

          People

          • Assignee:
            Dag H. Wanvik
            Reporter:
            Dag H. Wanvik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development