[DERBY-5413] NetworkServerControl#main can exit with status 1 without printing an error message to console

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 10.8.1.2
• Fix Version/s: 10.8.2.2, 10.9.1.0
• Component/s: Network Server
• Assignee: Dag H. Wanvik
• Reporter: Dag H. Wanvik
• Created: 15/Sep/11 10:19
• Updated: 17/Jun/13 09:19
• Resolved: 17/Nov/11 13:48

Description

Cf this piece of code in main

catch (Exception e)
{
//if there was an error, exit(1)
if ((e.getMessage() == null) ||
!e.getMessage().equals(NetworkServerControlImpl.UNEXPECTED_ERR) ||
printErrors
)

{ if (server != null) server.consoleExceptionPrint(e); else e.printStackTrace(); // default output stream is System.out }

// else, we've already printed a trace, so just exit.
System.exit(1);

The call "server.consoleExceptionPrint(e)" will actually not print anything unless the debug flag "NetworkServerControlImpl#debugOutput" has ben set to true which it isn't a priori.

I think it should be replaced by a call to server.consoleExceptionPrintTrace(e), which will print unconditionally.