Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5396

DRDAStatement and DRDAConnThread swallow IOExceptions

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 10.8.1.2
        • Fix Version/s: 10.8.2.2, 10.9.1.0
        • Component/s: Network Server
        • Labels:
          None

          Description

          DRDAConnThread.closeStream():

          } catch (IOException e)

          { Util.javaException(e); }

          DRDAStatement.execute():

          } catch (IOException e)

          { Util.javaException(e); }

          Since Util.javaException() only returns an exception, this code doesn't work as intended. The returned exception should also be thrown.

          1. File
            d5396.diff
            2 kB
            Knut Anders Hatlen

            Issue Links

            is duplicated by

            Bug - A problem which impairs or prevents the functions of the product. DERBY-4350 javaException is created but not thrown or logged in DRDAConnThread.closeStream(InputStream stream)

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              knutanders Knut Anders Hatlen added a comment -

              The attached patch makes the suggested changes. Running regression tests now.

              Show
              knutanders Knut Anders Hatlen added a comment - The attached patch makes the suggested changes. Running regression tests now.
              Hide
              Permalink
              kmarsden Kathey Marsden added a comment -

              There is issue DERBY-4350 which I am guessing can be closed as a duplicate of this, except that that issue also mentions the lack of logging, which is not addressed with the patch, but that would still be covered by DERBY-1191.

              Show
              kmarsden Kathey Marsden added a comment - There is issue DERBY-4350 which I am guessing can be closed as a duplicate of this, except that that issue also mentions the lack of logging, which is not addressed with the patch, but that would still be covered by DERBY-1191 .
              Hide
              Permalink
              knutanders Knut Anders Hatlen added a comment -

              Thanks, Kathey, the DRDAConnThread part of this issue is the same as DERBY-4350. I'll resolve that issue.

              All the regression tests passed. Committed revision 1163616.

              Show
              knutanders Knut Anders Hatlen added a comment - Thanks, Kathey, the DRDAConnThread part of this issue is the same as DERBY-4350 . I'll resolve that issue. All the regression tests passed. Committed revision 1163616.
              Hide
              Permalink
              myrna Myrna van Lunteren added a comment -

              reopen for backport.

              Show
              myrna Myrna van Lunteren added a comment - reopen for backport.
              Hide
              Permalink
              myrna Myrna van Lunteren added a comment -

              backported (with some minor manual editing of DRDAConnThread) with revision 1164755.

              Show
              myrna Myrna van Lunteren added a comment - backported (with some minor manual editing of DRDAConnThread) with revision 1164755.

                People

                • Assignee:
                  knutanders Knut Anders Hatlen
                  Reporter:
                  knutanders Knut Anders Hatlen
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development