Derby
  1. Derby
  2. DERBY-5314

Enable i18n tests in non-English locales

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.8.2.2, 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      The i18n tests are disabled if they are running in non-English locales. It would be good to have them running regardless of the locale.

      In Ole's nightly tests they are not running on Windows because of this. Seen for example last night when the i18n tests failed on all platforms, except on Windows:
      http://dbtg.foundry.sun.com/derby/test/Daily/jvm1.6/testing/Limited/testSummary-1143118.html

      There have been various improvements in ScriptTestCase lately to allow the canon-based tests to run in non-English locales, so I think it's safe to enable them now.

      1. d5314.diff
        4 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Knut Anders Hatlen created issue -
          Knut Anders Hatlen made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Knut Anders Hatlen made changes -
          Link This issue relates to DERBY-1726 [ DERBY-1726 ]
          Knut Anders Hatlen made changes -
          Link This issue relates to DERBY-5217 [ DERBY-5217 ]
          Hide
          Knut Anders Hatlen added a comment -

          The attached patch makes the i18n suite run regardless of locale. It also removes calls to LocalizedResource.resetLocalizedResourceCache() from the individual tests in the suite, since that is handled by ScriptTestCase after DERBY-5217 and not needed.

          The i18n suite ran successfully in my environment with the locale set to zh_CN.UTF-8 and ja_JP.eucJP.

          Show
          Knut Anders Hatlen added a comment - The attached patch makes the i18n suite run regardless of locale. It also removes calls to LocalizedResource.resetLocalizedResourceCache() from the individual tests in the suite, since that is handled by ScriptTestCase after DERBY-5217 and not needed. The i18n suite ran successfully in my environment with the locale set to zh_CN.UTF-8 and ja_JP.eucJP.
          Knut Anders Hatlen made changes -
          Attachment d5314.diff [ 12485405 ]
          Knut Anders Hatlen made changes -
          Issue & fix info [Patch Available]
          Hide
          Knut Anders Hatlen added a comment -

          Committed revision 1145057.

          Show
          Knut Anders Hatlen added a comment - Committed revision 1145057.
          Knut Anders Hatlen made changes -
          Status In Progress [ 3 ] Closed [ 6 ]
          Issue & fix info [Patch Available]
          Fix Version/s 10.9.0.0 [ 12316344 ]
          Resolution Fixed [ 1 ]
          Hide
          Myrna van Lunteren added a comment -

          reopen to backport to 10.8

          Show
          Myrna van Lunteren added a comment - reopen to backport to 10.8
          Myrna van Lunteren made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Hide
          Myrna van Lunteren added a comment -

          backported revision 11405057 together with revision 1137213 for DERBY-5217 with revision 1160433.

          Show
          Myrna van Lunteren added a comment - backported revision 11405057 together with revision 1137213 for DERBY-5217 with revision 1160433.
          Myrna van Lunteren made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Fix Version/s 10.8.1.6 [ 12316676 ]
          Resolution Fixed [ 1 ]
          Myrna van Lunteren made changes -
          Fix Version/s 10.8.2.0 [ 12317955 ]
          Fix Version/s 10.8.1.6 [ 12316676 ]
          Myrna van Lunteren made changes -
          Fix Version/s 10.8.2.2 [ 12317968 ]
          Fix Version/s 10.8.2.0 [ 12317955 ]
          Gavin made changes -
          Workflow jira [ 12619273 ] Default workflow, editable Closed status [ 12801165 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          4s 1 Knut Anders Hatlen 06/Jul/11 11:09
          In Progress In Progress Closed Closed
          4d 21h 49m 1 Knut Anders Hatlen 11/Jul/11 08:58
          Closed Closed Reopened Reopened
          42d 11h 48m 1 Myrna van Lunteren 22/Aug/11 20:47
          Reopened Reopened Closed Closed
          1h 24m 1 Myrna van Lunteren 22/Aug/11 22:11

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development