Derby
  1. Derby
  2. DERBY-5275

Remove empty, unused methods in client/am/Lob.java

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Network Client
    • Labels:
      None

      Description

      I noticed these two methods in client/am/Lob.java:

      void completeLocalRollback()

      { ; }

      void completeLocalCommit() { ; }

      They are not called anywhere, and could be removed.

      1. unused.diff
        0.5 kB
        Knut Anders Hatlen

        Activity

        Knut Anders Hatlen created issue -
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Knut Anders Hatlen added a comment -

        Attaching a patch that removes the methods.

        Show
        Knut Anders Hatlen added a comment - Attaching a patch that removes the methods.
        Knut Anders Hatlen made changes -
        Attachment unused.diff [ 12482533 ]
        Hide
        Knut Anders Hatlen added a comment -

        All the regression tests ran cleanly with these methods removed.

        Committed revision 1135545.

        Show
        Knut Anders Hatlen added a comment - All the regression tests ran cleanly with these methods removed. Committed revision 1135545.
        Knut Anders Hatlen made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow jira [ 12616600 ] Default workflow, editable Closed status [ 12801069 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        17m 27s 1 Knut Anders Hatlen 14/Jun/11 09:07
        In Progress In Progress Closed Closed
        3h 59m 1 Knut Anders Hatlen 14/Jun/11 13:07

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development