Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.8.1.2
    • Fix Version/s: 10.8.2.2, 10.9.1.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      It turns out to be possible to fix the two difficult problems I identified in a March 15, 2011 comment to DERBY-5135:

      1) The empty summary attributes in table elements

      2) The headers attributes that are invalid because of an extra space

      Some changes to the dita2htmlImpl.xsl file can resolve this problem.

      1. tadminimporting.html
        13 kB
        Kim Haase
      2. DERBY-5255.diff
        5 kB
        Kim Haase

        Activity

        Gavin made changes -
        Workflow jira [ 12615172 ] Default workflow, editable Closed status [ 12801059 ]
        Myrna van Lunteren made changes -
        Fix Version/s 10.8.2.2 [ 12317968 ]
        Fix Version/s 10.8.2.0 [ 12317955 ]
        Myrna van Lunteren made changes -
        Fix Version/s 10.8.2.0 [ 12317955 ]
        Fix Version/s 10.8.1.6 [ 12316676 ]
        Kim Haase made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Kim Haase added a comment -

        Fixes have appeared in Latest Alpha Manuals.

        Show
        Kim Haase added a comment - Fixes have appeared in Latest Alpha Manuals.
        Knut Anders Hatlen made changes -
        Fix Version/s 10.8.1.5 [ 12316676 ]
        Fix Version/s 10.8.1.4 [ 12316500 ]
        Rick Hillegas made changes -
        Fix Version/s 10.8.1.4 [ 12316500 ]
        Fix Version/s 10.8.1.3 [ 12316378 ]
        Kim Haase made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Issue & fix info [Patch Available]
        Fix Version/s 10.8.1.3 [ 12316378 ]
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Resolution Fixed [ 1 ]
        Hide
        Kim Haase added a comment -

        Committed patch DERBY-5255.diff to documentation trunk at revision 1133549.
        Merged to 10.8 doc branch at revision 1133550.

        Show
        Kim Haase added a comment - Committed patch DERBY-5255 .diff to documentation trunk at revision 1133549. Merged to 10.8 doc branch at revision 1133550.
        Hide
        Kim Haase added a comment -

        Thanks, Knut! I'll commit this in a few hours unless I hear otherwise.

        Show
        Kim Haase added a comment - Thanks, Knut! I'll commit this in a few hours unless I hear otherwise.
        Hide
        Knut Anders Hatlen added a comment -

        So this is what XSL looks like... I don't know enough XSL to comment on the code, except that the special handling of Hungarian looks a bit mysterious, but all the changes in the HTML generated for tadminimporting.html look like good improvements to me.

        Show
        Knut Anders Hatlen added a comment - So this is what XSL looks like... I don't know enough XSL to comment on the code, except that the special handling of Hungarian looks a bit mysterious, but all the changes in the HTML generated for tadminimporting.html look like good improvements to me.
        Kim Haase made changes -
        Issue & fix info [Patch Available]
        Kim Haase made changes -
        Field Original Value New Value
        Attachment DERBY-5255.diff [ 12481087 ]
        Attachment tadminimporting.html [ 12481088 ]
        Hide
        Kim Haase added a comment -

        Attaching DERBY-5255.diff, with the changes to lib/dita2htmlImpl.xsl, and tadminimporting.html, an output file containing a table, which shows the result of the change. The patch does the following:

        1) Adds a CREATE-CAPTION-TEXT template that uses the table's caption text to create a summary attribute for the table

        2) Uses the normalize-space function to remove the extra space from the headers attribute

        Please let me know if this patch seems suitable for commitment.

        Show
        Kim Haase added a comment - Attaching DERBY-5255 .diff, with the changes to lib/dita2htmlImpl.xsl, and tadminimporting.html, an output file containing a table, which shows the result of the change. The patch does the following: 1) Adds a CREATE-CAPTION-TEXT template that uses the table's caption text to create a summary attribute for the table 2) Uses the normalize-space function to remove the extra space from the headers attribute Please let me know if this patch seems suitable for commitment.
        Kim Haase created issue -

          People

          • Assignee:
            Kim Haase
            Reporter:
            Kim Haase
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development