Derby
  1. Derby
  2. DERBY-5254

The keywords introduced by the CREATE SEQUENCE work are treated as reserved rather than unreserved.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.6.1.0, 10.6.2.1, 10.7.1.1, 10.8.1.2
    • Fix Version/s: 10.6.2.4, 10.7.1.4, 10.8.2.2, 10.9.1.0
    • Component/s: SQL
    • Labels:
      None
    • Urgency:
      Normal
    • Issue & fix info:
      Known fix
    • Bug behavior facts:
      Regression, Seen in production

      Description

      The following keywords appear in the non-reserved keywords list in sqlgrammar.jj but are not included in nonReservedKeyword() production further down in that file. The intention was for the following words to be non-reserved keywords. But they are treated as reserved keywords. These keywords should be added to the nonReservedKeyword() production:

      MAXVALUE
      MINVALUE
      CYCLE

      Technically, these are supposed to be reserved keywords according to the Standard. However, we wanted to minimize disruption for users by making these non-reserved keywords--and it seems we failed to. Our good intentions are recorded in the functional spec attached to DERBY-712.

        Issue Links

          Activity

          Gavin made changes -
          Workflow jira [ 12615150 ] Default workflow, editable Closed status [ 12802649 ]
          Rick Hillegas made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Myrna van Lunteren made changes -
          Fix Version/s 10.8.2.2 [ 12317968 ]
          Fix Version/s 10.8.2.0 [ 12317955 ]
          Myrna van Lunteren made changes -
          Fix Version/s 10.8.2.0 [ 12317955 ]
          Fix Version/s 10.8.1.6 [ 12316676 ]
          Knut Anders Hatlen made changes -
          Fix Version/s 10.8.1.5 [ 12316676 ]
          Fix Version/s 10.8.1.4 [ 12316500 ]
          Rick Hillegas made changes -
          Fix Version/s 10.8.1.4 [ 12316500 ]
          Fix Version/s 10.8.1.3 [ 12316378 ]
          Rick Hillegas made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Issue & fix info [Patch Available, Known fix] [Known fix]
          Fix Version/s 10.6.2.3 [ 12315434 ]
          Fix Version/s 10.7.1.4 [ 12315902 ]
          Fix Version/s 10.8.1.3 [ 12316378 ]
          Fix Version/s 10.9.0.0 [ 12316344 ]
          Resolution Fixed [ 1 ]
          Hide
          Rick Hillegas added a comment -

          Ported 1130127 from trunk to 10.6 branch at subversion revision 1130139.

          Show
          Rick Hillegas added a comment - Ported 1130127 from trunk to 10.6 branch at subversion revision 1130139.
          Hide
          Rick Hillegas added a comment -

          Ported 1130127 from trunk to 10.7 branch at subversion revision 1130133.

          Show
          Rick Hillegas added a comment - Ported 1130127 from trunk to 10.7 branch at subversion revision 1130133.
          Rick Hillegas made changes -
          Link This issue is related to DERBY-712 [ DERBY-712 ]
          Hide
          Rick Hillegas added a comment -

          Ported 1130127 from trunk to 10.8 branch at subversion revision 1130130.

          Show
          Rick Hillegas added a comment - Ported 1130127 from trunk to 10.8 branch at subversion revision 1130130.
          Hide
          Rick Hillegas added a comment -

          Regression tests passed cleanly for me. Committed derby-5254-01-aa-unreserveKeywords.diff to trunk at subversion revision 1130127.

          Show
          Rick Hillegas added a comment - Regression tests passed cleanly for me. Committed derby-5254-01-aa-unreserveKeywords.diff to trunk at subversion revision 1130127.
          Rick Hillegas made changes -
          Issue & fix info [Known fix] [Known fix, Patch Available]
          Rick Hillegas made changes -
          Attachment derby-5254-01-aa-unreserveKeywords.diff [ 12480982 ]
          Hide
          Rick Hillegas added a comment -

          Attaching derby-5254-01-aa-unreserveKeywords.diff. This patch makes the CYCLE, MINVALUE, and MAXVALUE unreserved keywords. I am running regression tests now.

          Touches the following files:

          ---------

          M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj

          Adds CYCLE, MINVALUE, and MAXVALUE to the nonReservedKeywords() production.

          ---------

          M java/testing/org/apache/derbyTesting/functionTests/tests/lang/SequenceTest.java

          Adds a test case to verify that you can now create columns with these names.

          Show
          Rick Hillegas added a comment - Attaching derby-5254-01-aa-unreserveKeywords.diff. This patch makes the CYCLE, MINVALUE, and MAXVALUE unreserved keywords. I am running regression tests now. Touches the following files: --------- M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj Adds CYCLE, MINVALUE, and MAXVALUE to the nonReservedKeywords() production. --------- M java/testing/org/apache/derbyTesting/functionTests/tests/lang/SequenceTest.java Adds a test case to verify that you can now create columns with these names.
          Kathey Marsden made changes -
          Bug behavior facts [Seen in production] [Regression, Seen in production]
          Rick Hillegas made changes -
          Field Original Value New Value
          Assignee Rick Hillegas [ rhillegas ]
          Rick Hillegas created issue -

            People

            • Assignee:
              Rick Hillegas
              Reporter:
              Rick Hillegas
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development