Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5253

Engine code references org.apache.derby.shared.common.sanity.SanityManager

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.8.2.2, 10.9.1.0
    • Component/s: Miscellaneous
    • Labels:
      None

      Description

      Derby engine code is importing org.apache.derby.shared.common.sanity.SanityManager, causing sealing violations. See DERBY-4669 why this fix is inadequate.
      Even though this won't fix the/all problems, using shared.common.sanity.SanityManager on the client and iapi.services.sanity.SanityManager in the engine code is a simple rule to follow. Violations are also easily addressed.

        Issue Links

          Activity

          Hide
          kristwaa Kristian Waagan added a comment -

          Attached patch 1a, which replaces the imports from common with imports from iapi.

          Patch ready for review. I intend to commit this pretty soon.

          Show
          kristwaa Kristian Waagan added a comment - Attached patch 1a, which replaces the imports from common with imports from iapi. Patch ready for review. I intend to commit this pretty soon.
          Hide
          kristwaa Kristian Waagan added a comment -

          Committed patch 1a to trunk with revision 1130077.
          Closing issue.

          Show
          kristwaa Kristian Waagan added a comment - Committed patch 1a to trunk with revision 1130077. Closing issue.
          Hide
          kristwaa Kristian Waagan added a comment -

          Note the exception in iapi.services.info.JVMInfo. Here SanityManager is imported from shared.common to make it possible to keep iapi.services.sanity sealed. JVMInfo is included in both derby.jar and derbyclient.jar.

          Show
          kristwaa Kristian Waagan added a comment - Note the exception in iapi.services.info.JVMInfo. Here SanityManager is imported from shared.common to make it possible to keep iapi.services.sanity sealed. JVMInfo is included in both derby.jar and derbyclient.jar.
          Hide
          dagw Dag H. Wanvik added a comment -

          Would it be a good idea to make a small Wiki write-up on current state/ best practices when it comes to the use of shared code? It's not obvious..

          Show
          dagw Dag H. Wanvik added a comment - Would it be a good idea to make a small Wiki write-up on current state/ best practices when it comes to the use of shared code? It's not obvious..
          Hide
          kristwaa Kristian Waagan added a comment -

          Reopening for backport (needed for DERBY-4669).

          Show
          kristwaa Kristian Waagan added a comment - Reopening for backport (needed for DERBY-4669 ).
          Hide
          kristwaa Kristian Waagan added a comment -

          Backported to 10.8 with revision 1136020.
          Closing again.

          Show
          kristwaa Kristian Waagan added a comment - Backported to 10.8 with revision 1136020. Closing again.
          Hide
          kristwaa Kristian Waagan added a comment -

          Dag,

          Yes, a wiki could be a useful thing - or maybe freshen up the existing package.html we have.
          Before doing anything about this, I'd have to do some research though...

          Show
          kristwaa Kristian Waagan added a comment - Dag, Yes, a wiki could be a useful thing - or maybe freshen up the existing package.html we have. Before doing anything about this, I'd have to do some research though...

            People

            • Assignee:
              kristwaa Kristian Waagan
              Reporter:
              kristwaa Kristian Waagan
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development