Derby
  1. Derby
  2. DERBY-5211

Make SysinfoCPCheckTest pass in non-English locale

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.8.2.2, 10.9.1.0
    • Component/s: Test
    • Labels:

      Description

      SysinfoCPCheckTest failed in Chinese locale.

      D:\derby\test>java junit.textui.TestRunner org.apache.derbyTesting.functionTests
      .tests.tools.SysinfoCPCheckTest
      .F
      Time: 1.438
      There was 1 failure:
      1) testClassPathChecker(org.apache.derbyTesting.functionTests.tests.tools.Sysinf
      oCPCheckTest)junit.framework.ComparisonFailure: null expected:<[Testing for pres
      ence of all Derby-related libraries; typically, only some are needed.]> but was:
      <[测试所有与 Derby 相关的库是否存在;通常只需要其中的某些库。]>
      at org.apache.derbyTesting.functionTests.tests.tools.SysinfoCPCheckTest.
      testClassPathChecker(SysinfoCPCheckTest.java:157)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
      java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
      sorImpl.java:25)
      at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:
      112)

      FAILURES!!!
      Tests run: 1, Failures: 1, Errors: 0

        Issue Links

          Activity

          Hide
          Myrna van Lunteren added a comment -

          oops, got the revision for the backport wrong - it was 1157923. The automatic revision reflect tool's got it right.

          Show
          Myrna van Lunteren added a comment - oops, got the revision for the backport wrong - it was 1157923. The automatic revision reflect tool's got it right.
          Hide
          Myrna van Lunteren added a comment -

          backported to 10.8 branch with revision 1155367.

          Show
          Myrna van Lunteren added a comment - backported to 10.8 branch with revision 1155367.
          Hide
          Myrna van Lunteren added a comment -

          Reopen to document backport to 10.8

          Show
          Myrna van Lunteren added a comment - Reopen to document backport to 10.8
          Hide
          Bryan Pendleton added a comment -

          The patch looks fine to me, and the test passes with these changes in my environment. Committed to the svn trunk as revision 1098033.

          Thanks for the patch!

          Show
          Bryan Pendleton added a comment - The patch looks fine to me, and the test passes with these changes in my environment. Committed to the svn trunk as revision 1098033. Thanks for the patch!
          Hide
          Houx Zhang added a comment -

          As SysinfoCPCheckTest failed just because of error message, so it's OK to wrap the test in a Locale.English. Please check it.

          Show
          Houx Zhang added a comment - As SysinfoCPCheckTest failed just because of error message, so it's OK to wrap the test in a Locale.English. Please check it.

            People

            • Assignee:
              Houx Zhang
              Reporter:
              Houx Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development