Derby
  1. Derby
  2. DERBY-5204

Misplaced p tags in release notes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.8.1.2
    • Fix Version/s: 10.8.2.2, 10.9.1.0
    • Component/s: Build tools
    • Labels:
      None

      Description

      The HTML in the release notes doesn't pass the tests for HTML 4.01 Transitional at http://validator.w3.org. The problems are misplaced <p> tags:

      1) The list of supported Java and JDBC is enclosed in a <p> ... </p> section. A paragraph cannot contain block-level elements, like unordered lists - <ul>.

      2) The section that summarizes issues with release notes contains anchors with paragraphs nested inside them. Paragraphs cannot be nested inside anchors.

      1. tags.diff
        2 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        The attached patch attempts to fix the broken HTML by making these changes:

        1) Close the paragraph before starting the unordered list in releaseSummary.xml.

        2) Changed ReleaseNoteGenerator to use the inline grouping element <span> instead of <p> inside the anchors. The purpose of these <p> tags was just to group some elements together, so <span> sounds like a good match.

        With these changes, the release notes that got generated in my environment passed validation for HTML 4.01 Transitional. (They didn't pass HTML 4.01 Strict, though.)

        Show
        Knut Anders Hatlen added a comment - The attached patch attempts to fix the broken HTML by making these changes: 1) Close the paragraph before starting the unordered list in releaseSummary.xml. 2) Changed ReleaseNoteGenerator to use the inline grouping element <span> instead of <p> inside the anchors. The purpose of these <p> tags was just to group some elements together, so <span> sounds like a good match. With these changes, the release notes that got generated in my environment passed validation for HTML 4.01 Transitional. (They didn't pass HTML 4.01 Strict, though.)
        Hide
        Rick Hillegas added a comment -

        Thanks, Knut. These changes look good to me. +1

        Show
        Rick Hillegas added a comment - Thanks, Knut. These changes look good to me. +1
        Hide
        Knut Anders Hatlen added a comment -

        Thanks, Rick!

        Committed revision 1096741. Also back-ported to 10.8 with revision 1096746.

        Show
        Knut Anders Hatlen added a comment - Thanks, Rick! Committed revision 1096741. Also back-ported to 10.8 with revision 1096746.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development