code fetches data dictionary for no reason.
There is a section of comment in CreateIndexNode.bindStatement() about variable dd. Dave: Is it your intension to remove them also? It sounds like a logical thing to do to me. However, I cannot help but think there must be a reason the comment is there. I am running regression now just to see what happen.
My personal opinion is that you should remove all commented out code, that's what source code control is for,... but that's just my take, so if people feel better about changing my patch to just comment out that line, that's fine with me.
My personal opinion is the patch look good and we should rely on source code control. +1 for the patch. Suites.all and derbyall run clean with this patch. If there is no objection, I will commit this patch soon.
I've committed with revision 1075378. Thanks, Dave.
Resolving the issue since it seems to be done.
[bulk update] Close all resolved issues that haven't been updated for more than one year.