Derby
  1. Derby
  2. DERBY-5070

[patch] remove unused fetching of data dictionary

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.8.1.2
    • Component/s: SQL
    • Urgency:
      Low

      Description

      code fetches data dictionary for no reason.

        Activity

        Hide
        Lily Wei added a comment -

        There is a section of comment in CreateIndexNode.bindStatement() about variable dd. Dave: Is it your intension to remove them also? It sounds like a logical thing to do to me. However, I cannot help but think there must be a reason the comment is there. I am running regression now just to see what happen.

        Show
        Lily Wei added a comment - There is a section of comment in CreateIndexNode.bindStatement() about variable dd. Dave: Is it your intension to remove them also? It sounds like a logical thing to do to me. However, I cannot help but think there must be a reason the comment is there. I am running regression now just to see what happen.
        Hide
        Dave Brosius added a comment -

        My personal opinion is that you should remove all commented out code, that's what source code control is for,... but that's just my take, so if people feel better about changing my patch to just comment out that line, that's fine with me.

        Show
        Dave Brosius added a comment - My personal opinion is that you should remove all commented out code, that's what source code control is for,... but that's just my take, so if people feel better about changing my patch to just comment out that line, that's fine with me.
        Hide
        Lily Wei added a comment -

        My personal opinion is the patch look good and we should rely on source code control. +1 for the patch. Suites.all and derbyall run clean with this patch. If there is no objection, I will commit this patch soon.

        Show
        Lily Wei added a comment - My personal opinion is the patch look good and we should rely on source code control. +1 for the patch. Suites.all and derbyall run clean with this patch. If there is no objection, I will commit this patch soon.
        Hide
        Lily Wei added a comment -

        I've committed with revision 1075378. Thanks, Dave.

        Show
        Lily Wei added a comment - I've committed with revision 1075378. Thanks, Dave.
        Hide
        Knut Anders Hatlen added a comment -

        Resolving the issue since it seems to be done.

        Show
        Knut Anders Hatlen added a comment - Resolving the issue since it seems to be done.
        Hide
        Knut Anders Hatlen added a comment -

        [bulk update] Close all resolved issues that haven't been updated for more than one year.

        Show
        Knut Anders Hatlen added a comment - [bulk update] Close all resolved issues that haven't been updated for more than one year.

          People

          • Assignee:
            Dave Brosius
            Reporter:
            Dave Brosius
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development