Derby
  1. Derby
  2. DERBY-5055

[patch] add visibility to static method calls

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.8.1.2, 11.0.0.0
    • Component/s: Network Server
    • Labels:
      None
    • Urgency:
      Low
    • Issue & fix info:
      Patch Available
    • Bug behavior facts:
      Performance

      Description

      code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).

        Activity

        Dave Brosius created issue -
        Dave Brosius made changes -
        Field Original Value New Value
        Attachment static_visibility.diff [ 12471374 ]
        Hide
        Lily Wei added a comment -

        Wow! You are finding a lot of code that can be improve consistently. Awesome. Do you use any tool to help your finding?

        Show
        Lily Wei added a comment - Wow! You are finding a lot of code that can be improve consistently. Awesome. Do you use any tool to help your finding?
        Hide
        Dave Brosius added a comment -

        some of them are findbugs, others are found just by code inspection, after looking at 'unrelated' findbugs results.

        Show
        Dave Brosius added a comment - some of them are findbugs, others are found just by code inspection, after looking at 'unrelated' findbugs results.
        Hide
        Kathey Marsden added a comment -

        Thank you Dave for all the great fixes and welcome to the Derby
        community! Thank you Knut for picking up all those patches!

        We recently heard from Cesar Couto asking if we used findbugs:

        http://old.nabble.com/Do-Derby-developers-use-FindBugs--ts30762542.html#a30762542

        I'll cc him on this thread in case he is not subscribed to the list. I
        am sure he would be interested in your findbugs findings for his research.

        Kathey

        Show
        Kathey Marsden added a comment - Thank you Dave for all the great fixes and welcome to the Derby community! Thank you Knut for picking up all those patches! We recently heard from Cesar Couto asking if we used findbugs: http://old.nabble.com/Do-Derby-developers-use-FindBugs--ts30762542.html#a30762542 I'll cc him on this thread in case he is not subscribed to the list. I am sure he would be interested in your findbugs findings for his research. Kathey
        Hide
        Lily Wei added a comment -

        Thanks, Dave. Suites.all and derbyall run clean. If there is no object, I will commit the change.

        Show
        Lily Wei added a comment - Thanks, Dave. Suites.all and derbyall run clean. If there is no object, I will commit the change.
        Hide
        Knut Anders Hatlen added a comment -

        The patch looks fine to me. +1 to commit.

        Show
        Knut Anders Hatlen added a comment - The patch looks fine to me. +1 to commit.
        Hide
        Lily Wei added a comment -

        Thanks Dave for contribute the patch. Thanks Knut for reviewing it. I've committed with revision 1072817.

        Show
        Lily Wei added a comment - Thanks Dave for contribute the patch. Thanks Knut for reviewing it. I've committed with revision 1072817.
        Lily Wei made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Issue & fix info [Patch Available]
        Bug behavior facts [Performance]
        Assignee Dave Brosius [ dbrosius@apache.org ]
        Fix Version/s 10.8.0.0 [ 12315561 ]
        Resolution Fixed [ 1 ]
        Dave Brosius made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Rick Hillegas made changes -
        Fix Version/s 10.8.1.1 [ 12316356 ]
        Fix Version/s 10.8.1.0 [ 12315561 ]
        Rick Hillegas made changes -
        Fix Version/s 10.8.1.2 [ 12316362 ]
        Fix Version/s 10.8.1.1 [ 12316356 ]
        Gavin made changes -
        Workflow jira [ 12599281 ] Default workflow, editable Closed status [ 12801014 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4d 8h 29m 1 Lily Wei 22/Feb/11 16:28
        Resolved Resolved Closed Closed
        2h 42m 1 Dave Brosius 22/Feb/11 19:10

          People

          • Assignee:
            Dave Brosius
            Reporter:
            Dave Brosius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development