Derby
  1. Derby
  2. DERBY-5050

BrokeredConnection could call setHoldability() without using reflection

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.8.1.2
    • Fix Version/s: 10.8.1.2
    • Component/s: JDBC
    • Labels:
      None

      Description

      BrokeredConnection uses reflection to call Connection.setHoldability() because that method wasn't available in Java 1.3. Since Derby doesn't support Java 1.3 anymore, we could call the method directly.

      1. d5050.diff
        1 kB
        Knut Anders Hatlen

        Activity

        Knut Anders Hatlen created issue -
        Hide
        Knut Anders Hatlen added a comment -

        Attached patch removes the reflection code and calls setHoldability() directly. Running regression tests...

        Show
        Knut Anders Hatlen added a comment - Attached patch removes the reflection code and calls setHoldability() directly. Running regression tests...
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Attachment d5050.diff [ 12471209 ]
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1071558.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1071558.
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Issue & fix info [Patch Available]
        Fix Version/s 10.8.0.0 [ 12315561 ]
        Resolution Fixed [ 1 ]
        Rick Hillegas made changes -
        Affects Version/s 10.8.1.1 [ 12316356 ]
        Affects Version/s 10.8.1.0 [ 12315561 ]
        Fix Version/s 10.8.1.1 [ 12316356 ]
        Fix Version/s 10.8.1.0 [ 12315561 ]
        Rick Hillegas made changes -
        Affects Version/s 10.8.1.2 [ 12316362 ]
        Affects Version/s 10.8.1.1 [ 12316356 ]
        Fix Version/s 10.8.1.2 [ 12316362 ]
        Fix Version/s 10.8.1.1 [ 12316356 ]
        Gavin made changes -
        Workflow jira [ 12558241 ] Default workflow, editable Closed status [ 12799527 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        14h 35m 1 Knut Anders Hatlen 17/Feb/11 09:34

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development