Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5036

[patch] fix impossible comparison due to sign extension

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.7.1.1
    • 10.8.1.2
    • Network Server
    • None
    • Normal
    • Deviation from standard

    Description

      code does

      byte b = reader.readByte();
      if (b == 0xF1)
      database.sendTRGDFTRT = true;

      due to sign extension, this test will never be true.

      fixed

      Attachments

        1. bad_byte_compare.diff
          0.5 kB
          Dave Brosius

        Activity

          People

            dbrosius@apache.org Dave Brosius
            dbrosius@apache.org Dave Brosius
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified